[GitHub] arunlakshman commented on issue #103: [NEMO-11] Generalize Equality of Int Predicates for Loops

[GitBox <gi...@apache.org>]

arunlakshman commented on issue #103: [NEMO-11] Generalize Equality of Int Predicates for Loops
URL: https://github.com/apache/incubator-nemo/pull/103#issuecomment-414037656
 
 
   Hi @wonook, 
     Thanks for the detailed clarification. I still have some doubts about the method,
   - Should the method check for the equality of predicates in the range [`Integer.MIN_VALUE`,`Integer.MAX_VALUE`] **OR** [`0`,`Integer.MAX_VALUE`]
   - Should the method return the boolean value **OR**  the `boundary` at which the predicates starts conflicting 
   
   Please validate my approach to find the equality of the predicates
   ```
   for val in range[0,32]
      if isBoundary(2^val)
          break and return false
   ```
   If no boundary was obtained in the previous stage,
   ```
   for val in range [0,Integer.MAX_VALUE]
       if  isBboundary(val)
              break and return
   ```
   if no boundary was obtained in both the stages then `return true`.
   
   The performance of first stage in `O(log N)` and the second stage is `O(N)` and here `N` is the total no. of values in the test range.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services