[GitHub] [camel-k] gansheer commented on a diff in pull request #4568: feat(trait): Add maven profile to Integration in builder trait

["gansheer (via GitHub)" <gi...@apache.org>]

gansheer commented on code in PR #4568:
URL: https://github.com/apache/camel-k/pull/4568#discussion_r1262354188


##########
pkg/builder/project.go:
##########
@@ -191,3 +194,14 @@ func injectDependencies(ctx *builderContext) error {
 func sanitizeDependencies(ctx *builderContext) error {
 	return camel.SanitizeIntegrationDependencies(ctx.Maven.Project.Dependencies)
 }
+
+func injectProfile(ctx *builderContext) error {

Review Comment:
   I analyzed this option. There is a way to use an external file but it will limit the build functionnalities overides from the profile as stated in [the maven documentation](https://maven.apache.org/guides/introduction/introduction-to-profiles.html#which-areas-of-a-pom-can-be-customized-by-each-type-of-profile-w). This is the reason I decided to inject the content into the pom file. Let me know what you think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org