[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2715: [Bug]fix path split exception in win10,not check file existed

[GitBox <gi...@apache.org>]

TyrantLucifer commented on code in PR #2715:
URL: https://github.com/apache/incubator-seatunnel/pull/2715#discussion_r967734503


##########
seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/AbstractContainer.java:
##########
@@ -42,15 +43,14 @@ public abstract class AbstractContainer {
     protected final String startModuleFullPath;
 
     public AbstractContainer() {
-        String[] modules = getStartModulePath().split(File.separator);
-        this.startModuleName = modules[modules.length - 1];
-        this.startModuleFullPath = PROJECT_ROOT_PATH + File.separator +
-            START_ROOT_MODULE_NAME + File.separator + getStartModulePath();
+        this.startModuleName = getStartModuleName();
+        this.startModuleFullPath = PROJECT_ROOT_PATH + File.separator + START_ROOT_MODULE_NAME + File.separator + getStartModuleName();

Review Comment:
   change `getStartModuleName` to `this.startModuleName`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org