You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2018/12/06 11:16:26 UTC

svn commit: r1848285 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java

Author: tilman
Date: Thu Dec  6 11:16:26 2018
New Revision: 1848285

URL: http://svn.apache.org/viewvc?rev=1848285&view=rev
Log:
PDFBOX-4303, PDFBOX-4393: add comments

Modified:
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java?rev=1848285&r1=1848284&r2=1848285&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDAcroForm.java Thu Dec  6 11:16:26 2018
@@ -81,7 +81,7 @@ public final class PDAcroForm implements
     }
 
     /**
-     * Constructor.
+     * Constructor. Side effect: /Helv and /ZaDb fonts added with update mark.
      *
      * @param doc The document that this form is part of.
      * @param form The existing acroForm.
@@ -121,10 +121,12 @@ public final class PDAcroForm implements
             dictionary.setNeedToBeUpdated(true);
         }
 
-        // Adobe Acrobat uses Helvetica as a default font and 
+        // PDFBOX-3732: Adobe Acrobat uses Helvetica as a default font and 
         // stores that under the name '/Helv' in the resources dictionary
         // Zapf Dingbats is included per default for check boxes and 
         // radio buttons as /ZaDb.
+        // PDFBOX-4393: the two fonts are added by Adobe when signing
+        // and this breaks a previous signature. (Might be an Adobe bug)
         COSDictionary fontDict = defaultResources.getCOSObject().getCOSDictionary(COSName.FONT);
         if (fontDict == null)
         {