You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/08/29 08:15:43 UTC

[GitHub] [apisix-ingress-controller] nic-6443 commented on a diff in pull request #1277: fix config missing default_cluster_name yaml

nic-6443 commented on code in PR #1277:
URL: https://github.com/apache/apisix-ingress-controller/pull/1277#discussion_r957022120


##########
pkg/config/config_test.go:
##########
@@ -174,7 +177,8 @@ func TestConfigWithEnvVar(t *testing.T) {
     },
     "apisix": {
         "default_cluster_base_url": "{{.DEFAULT_CLUSTER_BASE_URL}}",
-        "default_cluster_admin_key": "{{.DEFAULT_CLUSTER_ADMIN_KEY}}"
+        "default_cluster_admin_key": "{{.DEFAULT_CLUSTER_ADMIN_KEY}}",
+		"default_cluster_name": "{{.DEFAULT_CLUSTER_NAME}}"

Review Comment:
   Bad indent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org