You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by max3163 <gi...@git.apache.org> on 2017/03/10 14:35:12 UTC
[GitHub] jmeter pull request #283: Allow on JMeter client to use variables and functi...
GitHub user max3163 opened a pull request:
https://github.com/apache/jmeter/pull/283
Allow on JMeter client to use variables and functions for Listener
This patch allow to use in all ResultCollector and Backend sampler (
which are executed in the client side for a distributed test ) to have
access on test plan and user defined variables.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/max3163/jmeter ClientVariable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/283.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #283
----
commit 35e0e0d1d02e2692a31651aabfcdb28c7065bd4c
Author: Maxime Chassagneux <ma...@gmail.com>
Date: 2017-03-10T14:32:31Z
Allow on JMeter client to use variables and functions for Listener
This patch allow to use in all ResultCollector and Backend sampler (
which are executed in the client side for a distributed test ) to have
access on test plan and user defined variables.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request #283: Allow on JMeter client to use variables and functi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/283
---
[GitHub] jmeter issue #283: Allow on JMeter client to use variables and functions for...
Posted by max3163 <gi...@git.apache.org>.
Github user max3163 commented on the issue:
https://github.com/apache/jmeter/pull/283
Hi,
No problem to delay it after 3.2.
I will include it in our own build and test it on a large scale.
I will think about JUnit to cover it as soon as possible.
Thanks again for your feedback.
Regards
--
Max
2017-03-10 19:57 GMT+01:00 Philippe M <no...@github.com>:
> Hello Maxime,
> Thanks for patch.
> My remarks:
>
> -
>
> I think we need here JUnit tests to check no regression will occur.
> This part of the code is complex and critical and needs 100% coverage
> ideally through JUnit otherwise with a test plan running with Jacoco
> -
>
> I would prefer to delay it after 3.2 release to avoid introducing
> another delay in release.
>
> I'll review code more thoroughly in near future.
>
> Regards
> Philippe
>
> \u2014
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/jmeter/pull/283#issuecomment-285754234>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ANMcZmviGUxaOWiQ3NIJDCxI82f5wg4Iks5rkZ0AgaJpZM4MZc7q>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter issue #283: Allow on JMeter client to use variables and functions for...
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/283
See:
http://svn.apache.org/viewvc?rev=1798405&view=rev
---
[GitHub] jmeter issue #283: Allow on JMeter client to use variables and functions for...
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/283
Hello Maxime,
Thanks for patch.
My remarks:
- I think we need here JUnit tests to check no regression will occur. This part of the code is complex and critical and needs 100% coverage ideally through JUnit otherwise with a test plan running with Jacoco
- I would prefer to delay it after 3.2 release to avoid introducing another delay in release.
I'll review code more thoroughly in near future.
Regards
Philippe
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---