[GitHub] [incubator-devlake] dwalker-sabiogroup opened a new pull request, #4835: fix: ensure Changelog IDs are numeric

["dwalker-sabiogroup (via GitHub)" <gi...@apache.org>]

dwalker-sabiogroup opened a new pull request, #4835:
URL: https://github.com/apache/incubator-devlake/pull/4835

   **Why**
   
   The current validation in convertIds function only guards against leading/trailing white space. This can cause an issue if other characters such as `[` or `]` are included in the ids input by the caller e.g. 123,[90],65
   
   Resulting in errors such as
   
   ```
   time="2023-03-30 12:46:45" level=error msg=" [pipeline service] [pipeline #1] run tasks failed
   	caused by: Error running task 70.
   	Wraps: (2) subtask convertIssueChangelogs ended unexpectedly
   	Wraps: (3) error calling Converter plugin implementation
   	Wraps: (4) strconv.ParseUint: parsing "[90]": invalid syntax
   	Wraps: (5) strconv.ParseUint: parsing "[90]"
   	Wraps: (6) invalid syntax
   	Error types: (1) *hintdetail.withDetail (2) *hintdetail.withDetail (3) *hintdetail.withDetail (4) *hintdetail.withDetail (5) *strconv.NumError (6) *errors.errorString
   ```
   
   **How**
   
   - Add a Regular Expression to match any repeated numeric characters
   - Return the first match of the regular expression as the item ID
   
   The above will prevent parseUint from returning an error and resolve https://github.com/apache/incubator-devlake/issues/4827
   
   ### ⚠️ Pre Checklist
   
   > Please complete _ALL_ items in this checklist, and remove before submitting
   
   - [ ] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
   - [ ] I have added relevant tests.
   - [ ] I have added relevant documentation.
   - [ ] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
   
   <!--
   Thanks for submitting a pull request!
   
   We appreciate you spending the time to work on these changes.
   Please fill out as many sections below as possible.
   -->
   
   ### Summary
   What does this PR do?
   
   ### Does this close any open issues?
   Closes xx
   
   ### Screenshots
   Include any relevant screenshots here.
   
   ### Other Information
   Any other information that is important to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] abeizn merged pull request #4835: fix: ensure Changelog IDs are numeric

["abeizn (via GitHub)" <gi...@apache.org>]

abeizn merged PR #4835:
URL: https://github.com/apache/incubator-devlake/pull/4835


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org