You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/28 11:02:06 UTC
[GitHub] [inlong] EMsnap opened a new pull request, #5254: [INLONG-5158][Sort] Sort add metric for kafka source with flink metrics group and audit sdk
EMsnap opened a new pull request, #5254:
URL: https://github.com/apache/inlong/pull/5254
### [INLONG-5158][Sort] Sort add metric for kafka source with flink metrics group and audit sdk
- Fixes #5158
### Motivation
add metric for kafka source with flink metrics group and audit sdk
### Modifications
add metric for kafka source with flink metrics group and audit sdk
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap merged pull request #5254: [INLONG-5158][Sort] Sort add metric for kafka source with flink metrics group and audit sdk
Posted by GitBox <gi...@apache.org>.
EMsnap merged PR #5254:
URL: https://github.com/apache/inlong/pull/5254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #5254: [INLONG-5158][Sort] Sort add metric for kafka source with flink metrics group and audit sdk
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #5254:
URL: https://github.com/apache/inlong/pull/5254#discussion_r940032599
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/GroupInfo.java:
##########
@@ -39,6 +40,9 @@ public class GroupInfo implements Serializable {
@JsonProperty("streams")
private List<StreamInfo> streams;
+ @JsonProperty("extraInfo")
+ private Properties extraInfo;
Review Comment:
Maybe Properties extraInfo -> Map<String,String> properties ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap commented on a diff in pull request #5254: [INLONG-5158][Sort] Sort add metric for kafka source with flink metrics group and audit sdk
Posted by GitBox <gi...@apache.org>.
EMsnap commented on code in PR #5254:
URL: https://github.com/apache/inlong/pull/5254#discussion_r940037441
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/GroupInfo.java:
##########
@@ -39,6 +40,9 @@ public class GroupInfo implements Serializable {
@JsonProperty("streams")
private List<StreamInfo> streams;
+ @JsonProperty("extraInfo")
+ private Properties extraInfo;
Review Comment:
thanks for your advice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on a diff in pull request #5254: [INLONG-5158][Sort] Sort add metric for kafka source with flink metrics group and audit sdk
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #5254:
URL: https://github.com/apache/inlong/pull/5254#discussion_r940865801
##########
inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/table/DynamicKafkaDeserializationSchema.java:
##########
@@ -0,0 +1,346 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.kafka.table;
+
+import static org.apache.inlong.sort.base.Constants.DELIMITER;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import javax.annotation.Nullable;
+import org.apache.flink.api.common.serialization.DeserializationSchema;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.streaming.connectors.kafka.KafkaDeserializationSchema;
+import org.apache.flink.streaming.connectors.kafka.table.KafkaDynamicSource;
+import org.apache.flink.table.data.GenericRowData;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.types.DeserializationException;
+import org.apache.flink.types.RowKind;
+import org.apache.flink.util.Collector;
+import org.apache.flink.util.Preconditions;
+import org.apache.inlong.audit.AuditImp;
+import org.apache.inlong.sort.base.Constants;
+import org.apache.inlong.sort.base.metric.SourceMetricData;
+import org.apache.kafka.clients.consumer.ConsumerRecord;
+
+/**
+ * deserialization schema for {@link KafkaDynamicSource}.
+ */
+class DynamicKafkaDeserializationSchema implements KafkaDeserializationSchema<RowData> {
+
+ private static final long serialVersionUID = 1L;
+
+ private final @Nullable DeserializationSchema<RowData> keyDeserialization;
+
+ private final DeserializationSchema<RowData> valueDeserialization;
+
+ private final boolean hasMetadata;
+
+ private final BufferingCollector keyCollector;
+
+ private final OutputProjectionCollector outputCollector;
+
+ private final TypeInformation<RowData> producedTypeInfo;
+
+ private final boolean upsertMode;
+
+ private final String inlongMetric;
+
+ private SourceMetricData metricData;
+
+ private String inLongGroupId;
+
+ private String auditHostAndPorts;
+
+ private String inLongStreamId;
+
+ private transient AuditImp auditImp;
+
+ DynamicKafkaDeserializationSchema(
+ int physicalArity,
+ @Nullable DeserializationSchema<RowData> keyDeserialization,
+ int[] keyProjection,
+ DeserializationSchema<RowData> valueDeserialization,
+ int[] valueProjection,
+ boolean hasMetadata,
+ MetadataConverter[] metadataConverters,
+ TypeInformation<RowData> producedTypeInfo,
+ boolean upsertMode,
+ String inLongMetric,
+ String auditHostAndPorts) {
+ if (upsertMode) {
+ Preconditions.checkArgument(
+ keyDeserialization != null && keyProjection.length > 0,
+ "Key must be set in upsert mode for deserialization schema.");
+ }
+ this.keyDeserialization = keyDeserialization;
+ this.valueDeserialization = valueDeserialization;
+ this.hasMetadata = hasMetadata;
+ this.keyCollector = new BufferingCollector();
+ this.outputCollector =
+ new OutputProjectionCollector(
+ physicalArity,
+ keyProjection,
+ valueProjection,
+ metadataConverters,
+ upsertMode);
+ this.producedTypeInfo = producedTypeInfo;
+ this.upsertMode = upsertMode;
+ this.inlongMetric = inLongMetric;
+ this.auditHostAndPorts = auditHostAndPorts;
+
+ }
+
+ @Override
+ public void open(DeserializationSchema.InitializationContext context) throws Exception {
+ if (keyDeserialization != null) {
+ keyDeserialization.open(context);
+ }
+ valueDeserialization.open(context);
+ if (inlongMetric != null && !inlongMetric.isEmpty()) {
+ String[] inLongMetricArray = inlongMetric.split(DELIMITER);
+ inLongGroupId = inLongMetricArray[0];
+ inLongStreamId = inLongMetricArray[1];
+ String nodeId = inLongMetricArray[2];
+ metricData = new SourceMetricData(context.getMetricGroup());
+ metricData.registerMetricsForNumBytesIn(inLongGroupId, inLongStreamId, nodeId, "numBytesIn");
+ metricData.registerMetricsForNumBytesInPerSecond(inLongGroupId, inLongStreamId,
+ nodeId, "numBytesInPerSecond");
+ metricData.registerMetricsForNumRecordsIn(inLongGroupId, inLongStreamId,
+ nodeId, "numRecordsIn");
+ metricData.registerMetricsForNumRecordsInPerSecond(inLongGroupId, inLongStreamId,
+ nodeId, "numRecordsInPerSecond");
+ }
+ if (auditHostAndPorts != null) {
+ AuditImp.getInstance().setAuditProxy(new HashSet<>(Arrays.asList(auditHostAndPorts.split(DELIMITER))));
+ auditImp = AuditImp.getInstance();
+ }
+ }
+
+ @Override
+ public boolean isEndOfStream(RowData nextElement) {
+ return false;
+ }
+
+ @Override
+ public RowData deserialize(ConsumerRecord<byte[], byte[]> record) throws Exception {
+ throw new IllegalStateException("A collector is required for deserializing.");
+ }
+
+ @Override
+ public void deserialize(ConsumerRecord<byte[], byte[]> record, Collector<RowData> collector)
+ throws Exception {
+ // shortcut in case no output projection is required,
+ // also not for a cartesian product with the keys
+ if (keyDeserialization == null && !hasMetadata) {
+ valueDeserialization.deserialize(record.value(), collector);
+ // output metrics
+ outputMetrics(record);
+ return;
+ }
+
+ // buffer key(s)
+ if (keyDeserialization != null) {
+ keyDeserialization.deserialize(record.key(), keyCollector);
+ }
+
+ // project output while emitting values
+ outputCollector.inputRecord = record;
+ outputCollector.physicalKeyRows = keyCollector.buffer;
+ outputCollector.outputCollector = collector;
+
+ if (record.value() == null && upsertMode) {
+ // collect tombstone messages in upsert mode by hand
+ outputCollector.collect(null);
+ } else {
+ valueDeserialization.deserialize(record.value(), outputCollector);
+ // output metrics
+ outputMetrics(record);
+ }
+
+ keyCollector.buffer.clear();
+ }
+
+ private void outputMetrics(ConsumerRecord<byte[], byte[]> record) {
+ outputMetricForFlink(record);
+ outputMetricForAudit(record);
+ }
+
+ private void outputMetricForAudit(ConsumerRecord<byte[], byte[]> record) {
+ if (auditImp != null) {
+ auditImp.add(
+ Constants.AUDIT_SORT_INPUT,
+ inLongGroupId,
+ inLongStreamId,
Review Comment:
If inlong metric is null, here inlongGroupId and inlongStreamId is null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on pull request #5254: [INLONG-5158][Sort] Sort add metric for kafka source with flink metrics group and audit sdk
Posted by GitBox <gi...@apache.org>.
gong commented on PR #5254:
URL: https://github.com/apache/inlong/pull/5254#issuecomment-1208886331
I suggest that expose setting of auditing. For example, send data frequency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on a diff in pull request #5254: [INLONG-5158][Sort] Sort add metric for kafka source with flink metrics group and audit sdk
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #5254:
URL: https://github.com/apache/inlong/pull/5254#discussion_r940865801
##########
inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/table/DynamicKafkaDeserializationSchema.java:
##########
@@ -0,0 +1,346 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.kafka.table;
+
+import static org.apache.inlong.sort.base.Constants.DELIMITER;
+
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import javax.annotation.Nullable;
+import org.apache.flink.api.common.serialization.DeserializationSchema;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.streaming.connectors.kafka.KafkaDeserializationSchema;
+import org.apache.flink.streaming.connectors.kafka.table.KafkaDynamicSource;
+import org.apache.flink.table.data.GenericRowData;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.types.DeserializationException;
+import org.apache.flink.types.RowKind;
+import org.apache.flink.util.Collector;
+import org.apache.flink.util.Preconditions;
+import org.apache.inlong.audit.AuditImp;
+import org.apache.inlong.sort.base.Constants;
+import org.apache.inlong.sort.base.metric.SourceMetricData;
+import org.apache.kafka.clients.consumer.ConsumerRecord;
+
+/**
+ * deserialization schema for {@link KafkaDynamicSource}.
+ */
+class DynamicKafkaDeserializationSchema implements KafkaDeserializationSchema<RowData> {
+
+ private static final long serialVersionUID = 1L;
+
+ private final @Nullable DeserializationSchema<RowData> keyDeserialization;
+
+ private final DeserializationSchema<RowData> valueDeserialization;
+
+ private final boolean hasMetadata;
+
+ private final BufferingCollector keyCollector;
+
+ private final OutputProjectionCollector outputCollector;
+
+ private final TypeInformation<RowData> producedTypeInfo;
+
+ private final boolean upsertMode;
+
+ private final String inlongMetric;
+
+ private SourceMetricData metricData;
+
+ private String inLongGroupId;
+
+ private String auditHostAndPorts;
+
+ private String inLongStreamId;
+
+ private transient AuditImp auditImp;
+
+ DynamicKafkaDeserializationSchema(
+ int physicalArity,
+ @Nullable DeserializationSchema<RowData> keyDeserialization,
+ int[] keyProjection,
+ DeserializationSchema<RowData> valueDeserialization,
+ int[] valueProjection,
+ boolean hasMetadata,
+ MetadataConverter[] metadataConverters,
+ TypeInformation<RowData> producedTypeInfo,
+ boolean upsertMode,
+ String inLongMetric,
+ String auditHostAndPorts) {
+ if (upsertMode) {
+ Preconditions.checkArgument(
+ keyDeserialization != null && keyProjection.length > 0,
+ "Key must be set in upsert mode for deserialization schema.");
+ }
+ this.keyDeserialization = keyDeserialization;
+ this.valueDeserialization = valueDeserialization;
+ this.hasMetadata = hasMetadata;
+ this.keyCollector = new BufferingCollector();
+ this.outputCollector =
+ new OutputProjectionCollector(
+ physicalArity,
+ keyProjection,
+ valueProjection,
+ metadataConverters,
+ upsertMode);
+ this.producedTypeInfo = producedTypeInfo;
+ this.upsertMode = upsertMode;
+ this.inlongMetric = inLongMetric;
+ this.auditHostAndPorts = auditHostAndPorts;
+
+ }
+
+ @Override
+ public void open(DeserializationSchema.InitializationContext context) throws Exception {
+ if (keyDeserialization != null) {
+ keyDeserialization.open(context);
+ }
+ valueDeserialization.open(context);
+ if (inlongMetric != null && !inlongMetric.isEmpty()) {
+ String[] inLongMetricArray = inlongMetric.split(DELIMITER);
+ inLongGroupId = inLongMetricArray[0];
+ inLongStreamId = inLongMetricArray[1];
+ String nodeId = inLongMetricArray[2];
+ metricData = new SourceMetricData(context.getMetricGroup());
+ metricData.registerMetricsForNumBytesIn(inLongGroupId, inLongStreamId, nodeId, "numBytesIn");
+ metricData.registerMetricsForNumBytesInPerSecond(inLongGroupId, inLongStreamId,
+ nodeId, "numBytesInPerSecond");
+ metricData.registerMetricsForNumRecordsIn(inLongGroupId, inLongStreamId,
+ nodeId, "numRecordsIn");
+ metricData.registerMetricsForNumRecordsInPerSecond(inLongGroupId, inLongStreamId,
+ nodeId, "numRecordsInPerSecond");
+ }
+ if (auditHostAndPorts != null) {
+ AuditImp.getInstance().setAuditProxy(new HashSet<>(Arrays.asList(auditHostAndPorts.split(DELIMITER))));
+ auditImp = AuditImp.getInstance();
+ }
+ }
+
+ @Override
+ public boolean isEndOfStream(RowData nextElement) {
+ return false;
+ }
+
+ @Override
+ public RowData deserialize(ConsumerRecord<byte[], byte[]> record) throws Exception {
+ throw new IllegalStateException("A collector is required for deserializing.");
+ }
+
+ @Override
+ public void deserialize(ConsumerRecord<byte[], byte[]> record, Collector<RowData> collector)
+ throws Exception {
+ // shortcut in case no output projection is required,
+ // also not for a cartesian product with the keys
+ if (keyDeserialization == null && !hasMetadata) {
+ valueDeserialization.deserialize(record.value(), collector);
+ // output metrics
+ outputMetrics(record);
+ return;
+ }
+
+ // buffer key(s)
+ if (keyDeserialization != null) {
+ keyDeserialization.deserialize(record.key(), keyCollector);
+ }
+
+ // project output while emitting values
+ outputCollector.inputRecord = record;
+ outputCollector.physicalKeyRows = keyCollector.buffer;
+ outputCollector.outputCollector = collector;
+
+ if (record.value() == null && upsertMode) {
+ // collect tombstone messages in upsert mode by hand
+ outputCollector.collect(null);
+ } else {
+ valueDeserialization.deserialize(record.value(), outputCollector);
+ // output metrics
+ outputMetrics(record);
+ }
+
+ keyCollector.buffer.clear();
+ }
+
+ private void outputMetrics(ConsumerRecord<byte[], byte[]> record) {
+ outputMetricForFlink(record);
+ outputMetricForAudit(record);
+ }
+
+ private void outputMetricForAudit(ConsumerRecord<byte[], byte[]> record) {
+ if (auditImp != null) {
+ auditImp.add(
+ Constants.AUDIT_SORT_INPUT,
+ inLongGroupId,
+ inLongStreamId,
Review Comment:
If inlong metric is null, here inlongGroupId and inlongStreamId is null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org