You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wjones127 (via GitHub)" <gi...@apache.org> on 2023/03/13 18:15:28 UTC
[GitHub] [arrow] wjones127 opened a new pull request, #34549: GH-34546: [C++] Support casting from large string to string scalar
wjones127 opened a new pull request, #34549:
URL: https://github.com/apache/arrow/pull/34549
### Rationale for this change
We rely on scalar casting to create partition values. Some systems, such as Polars, always use LargeString arrays instead of String, so we need to make sure we can handle those partition values correctly.
### What changes are included in this PR?
Adds casting function for `LargeStringScalar` and `LargeBinaryScalar` to `StringScalar`.
Tests that we correctly format Hive partition values for large string.
### Are these changes tested?
The casting functions are implicitly tested in other places (like the test added). There are no existing tests for `CastTo` for binary/string scalars.
### Are there any user-facing changes?
Fixes a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34549: GH-34546: [C++] Support casting from large string to string scalar
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34549:
URL: https://github.com/apache/arrow/pull/34549#issuecomment-1469333217
Benchmark runs are scheduled for baseline = b7fa29bc6f934848ce4946f408cbc8fa98ae784b and contender = 8732b2785804d3c75c2e7c551ebec5e787214b47. 8732b2785804d3c75c2e7c551ebec5e787214b47 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f7d267aff1384ebfb2264ad05e447450...fbd1dc9ff21a474583ef5ae9560ff203/)
[Failed :arrow_down:0.39% :arrow_up:0.06%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a73417855f02437db80214c9889b4d19...9357e3b31cdc404ca5c12926ee9f4983/)
[Finished :arrow_down:0.0% :arrow_up:0.51%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/05aa0d689c224872939028a8c8d0b16f...bfd8bd31da814d39815a0236637216be/)
[Finished :arrow_down:0.44% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9b4fc2a2352c4421b2264deae3a6ac3a...4dd409c847f242dd9ba5193fb3b861dd/)
Buildkite builds:
[Finished] [`8732b278` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2524)
[Finished] [`8732b278` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2555)
[Finished] [`8732b278` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2523)
[Finished] [`8732b278` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2546)
[Finished] [`b7fa29bc` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2523)
[Failed] [`b7fa29bc` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2553)
[Finished] [`b7fa29bc` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2521)
[Finished] [`b7fa29bc` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2544)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 merged pull request #34549: GH-34546: [C++] Support casting from large string to string scalar
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 merged PR #34549:
URL: https://github.com/apache/arrow/pull/34549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34549: GH-34546: [C++] Support casting from large string to string scalar
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34549:
URL: https://github.com/apache/arrow/pull/34549#issuecomment-1466669967
* Closes: #34546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org