[GitHub] [spark] cloud-fan commented on a diff in pull request #42763: [SPARK-44735][SQL] Add warning msg when inserting columns with the same name by row that don't match up

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #42763:
URL: https://github.com/apache/spark/pull/42763#discussion_r1312966146


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala:
##########
@@ -403,11 +403,19 @@ object PreprocessTableInsertion extends ResolveInsertionBase {
       insert.query
     }
     val newQuery = try {
+      val byName = hasColumnList || insert.byName

Review Comment:
   this is only for v1 table, does v1 table have the same problem?



##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala:
##########
@@ -403,11 +403,19 @@ object PreprocessTableInsertion extends ResolveInsertionBase {
       insert.query
     }
     val newQuery = try {
+      val byName = hasColumnList || insert.byName

Review Comment:
   this is only for v1 table, does v2 table have the same problem?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org