You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Joel Koshy <jj...@gmail.com> on 2014/04/08 23:22:21 UTC
Review Request 20130: Patch for KAFKA-1373
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20130/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1373
https://issues.apache.org/jira/browse/KAFKA-1373
Repository: kafka
Description
-------
fix
Diffs
-----
core/src/main/scala/kafka/log/LogCleanerManager.scala 6a981345fd7dc711e6c4f058a42bd7f8f9d350fe
core/src/main/scala/kafka/server/OffsetCheckpoint.scala 19f61a9718a7f8e6f9bf743ac9eb2118d0fdd9b0
Diff: https://reviews.apache.org/r/20130/diff/
Testing
-------
Thanks,
Joel Koshy
Re: Review Request 20130: Patch for KAFKA-1373
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20130/#review39839
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On April 8, 2014, 11:18 p.m., Joel Koshy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20130/
> -----------------------------------------------------------
>
> (Updated April 8, 2014, 11:18 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1373
> https://issues.apache.org/jira/browse/KAFKA-1373
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Set first dirty (uncompacted) offset to first offset of the log if no checkpoint exists.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/LogCleanerManager.scala 6a981345fd7dc711e6c4f058a42bd7f8f9d350fe
> core/src/main/scala/kafka/server/KafkaConfig.scala b0506d4881176cd95914847c4275e428a8d2ca10
> core/src/main/scala/kafka/server/OffsetCheckpoint.scala 19f61a9718a7f8e6f9bf743ac9eb2118d0fdd9b0
> core/src/main/scala/kafka/server/OffsetManager.scala 89a88a7e4055f804429b64e85b2f65312d1e2155
> core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 9aeb69d4934b9aa94e0899af14fc27e7c20f039f
>
> Diff: https://reviews.apache.org/r/20130/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joel Koshy
>
>
Re: Review Request 20130: Patch for KAFKA-1373
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20130/#review40078
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On April 8, 2014, 11:18 p.m., Joel Koshy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20130/
> -----------------------------------------------------------
>
> (Updated April 8, 2014, 11:18 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1373
> https://issues.apache.org/jira/browse/KAFKA-1373
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Set first dirty (uncompacted) offset to first offset of the log if no checkpoint exists.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/LogCleanerManager.scala 6a981345fd7dc711e6c4f058a42bd7f8f9d350fe
> core/src/main/scala/kafka/server/KafkaConfig.scala b0506d4881176cd95914847c4275e428a8d2ca10
> core/src/main/scala/kafka/server/OffsetCheckpoint.scala 19f61a9718a7f8e6f9bf743ac9eb2118d0fdd9b0
> core/src/main/scala/kafka/server/OffsetManager.scala 89a88a7e4055f804429b64e85b2f65312d1e2155
> core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 9aeb69d4934b9aa94e0899af14fc27e7c20f039f
>
> Diff: https://reviews.apache.org/r/20130/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joel Koshy
>
>
Re: Review Request 20130: Patch for KAFKA-1373
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20130/#review39862
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On April 8, 2014, 11:18 p.m., Joel Koshy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20130/
> -----------------------------------------------------------
>
> (Updated April 8, 2014, 11:18 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1373
> https://issues.apache.org/jira/browse/KAFKA-1373
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Set first dirty (uncompacted) offset to first offset of the log if no checkpoint exists.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/LogCleanerManager.scala 6a981345fd7dc711e6c4f058a42bd7f8f9d350fe
> core/src/main/scala/kafka/server/KafkaConfig.scala b0506d4881176cd95914847c4275e428a8d2ca10
> core/src/main/scala/kafka/server/OffsetCheckpoint.scala 19f61a9718a7f8e6f9bf743ac9eb2118d0fdd9b0
> core/src/main/scala/kafka/server/OffsetManager.scala 89a88a7e4055f804429b64e85b2f65312d1e2155
> core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 9aeb69d4934b9aa94e0899af14fc27e7c20f039f
>
> Diff: https://reviews.apache.org/r/20130/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joel Koshy
>
>
Re: Review Request 20130: Patch for KAFKA-1373
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20130/#review39863
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy Chen
On April 8, 2014, 11:18 p.m., Joel Koshy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20130/
> -----------------------------------------------------------
>
> (Updated April 8, 2014, 11:18 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1373
> https://issues.apache.org/jira/browse/KAFKA-1373
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Set first dirty (uncompacted) offset to first offset of the log if no checkpoint exists.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/LogCleanerManager.scala 6a981345fd7dc711e6c4f058a42bd7f8f9d350fe
> core/src/main/scala/kafka/server/KafkaConfig.scala b0506d4881176cd95914847c4275e428a8d2ca10
> core/src/main/scala/kafka/server/OffsetCheckpoint.scala 19f61a9718a7f8e6f9bf743ac9eb2118d0fdd9b0
> core/src/main/scala/kafka/server/OffsetManager.scala 89a88a7e4055f804429b64e85b2f65312d1e2155
> core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 9aeb69d4934b9aa94e0899af14fc27e7c20f039f
>
> Diff: https://reviews.apache.org/r/20130/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joel Koshy
>
>
Re: Review Request 20130: Patch for KAFKA-1373
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20130/
-----------------------------------------------------------
(Updated April 8, 2014, 11:18 p.m.)
Review request for kafka.
Bugs: KAFKA-1373
https://issues.apache.org/jira/browse/KAFKA-1373
Repository: kafka
Description (updated)
-------
Set first dirty (uncompacted) offset to first offset of the log if no checkpoint exists.
Diffs (updated)
-----
core/src/main/scala/kafka/log/LogCleanerManager.scala 6a981345fd7dc711e6c4f058a42bd7f8f9d350fe
core/src/main/scala/kafka/server/KafkaConfig.scala b0506d4881176cd95914847c4275e428a8d2ca10
core/src/main/scala/kafka/server/OffsetCheckpoint.scala 19f61a9718a7f8e6f9bf743ac9eb2118d0fdd9b0
core/src/main/scala/kafka/server/OffsetManager.scala 89a88a7e4055f804429b64e85b2f65312d1e2155
core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 9aeb69d4934b9aa94e0899af14fc27e7c20f039f
Diff: https://reviews.apache.org/r/20130/diff/
Testing
-------
Thanks,
Joel Koshy