You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@santuario.apache.org by co...@apache.org on 2011/10/05 12:00:37 UTC
svn commit: r1179132 -
/santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/transforms/implementations/TransformXPath2Filter.java
Author: coheigea
Date: Wed Oct 5 10:00:37 2011
New Revision: 1179132
URL: http://svn.apache.org/viewvc?rev=1179132&view=rev
Log:
Fixing a minor performance issue in the TransformXPath2Filter
Modified:
santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/transforms/implementations/TransformXPath2Filter.java
Modified: santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/transforms/implementations/TransformXPath2Filter.java
URL: http://svn.apache.org/viewvc/santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/transforms/implementations/TransformXPath2Filter.java?rev=1179132&r1=1179131&r2=1179132&view=diff
==============================================================================
--- santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/transforms/implementations/TransformXPath2Filter.java (original)
+++ santuario/xml-security-java/trunk/src/main/java/org/apache/xml/security/transforms/implementations/TransformXPath2Filter.java Wed Oct 5 10:00:37 2011
@@ -89,15 +89,13 @@ public class TransformXPath2Filter exten
CachedXPathFuncHereAPI xPathFuncHereAPI =
new CachedXPathFuncHereAPI(CachedXPathAPIHolder.getCachedXPathAPI());
- Element []xpathElements =
+ Element[] xpathElements =
XMLUtils.selectNodes(
transformObject.getElement().getFirstChild(),
XPath2FilterContainer.XPathFilter2NS,
XPath2FilterContainer._TAG_XPATH2
);
- int noOfSteps = xpathElements.length;
-
- if (noOfSteps == 0) {
+ if (xpathElements.length == 0) {
Object exArgs[] = { Transforms.TRANSFORM_XPATH2FILTER, "XPath" };
throw new TransformationException("xml.WrongContent", exArgs);
@@ -110,14 +108,9 @@ public class TransformXPath2Filter exten
inputDoc = XMLUtils.getOwnerDocument(input.getNodeSet());
}
- for (int i = 0; i < noOfSteps; i++) {
- Element xpathElement =
- XMLUtils.selectNode(
- transformObject.getElement().getFirstChild(),
- XPath2FilterContainer.XPathFilter2NS,
- XPath2FilterContainer._TAG_XPATH2,
- i
- );
+ for (int i = 0; i < xpathElements.length; i++) {
+ Element xpathElement = xpathElements[i];
+
XPath2FilterContainer xpathContainer =
XPath2FilterContainer.newInstance(xpathElement, input.getSourceURI());