You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/10/12 13:58:21 UTC

[GitHub] [incubator-streampark] ziqiang-wang opened a new pull request, #1826: [bug] [fix] [streampark-flink-shims-base] Repair multiple dialect set statement have no effect error.

ziqiang-wang opened a new pull request, #1826:
URL: https://github.com/apache/incubator-streampark/pull/1826

   Repair multiple dialect set statement have no effect error.
   
   Cause:The sql statement sorts the results at the end of the parseSQL function, disrupting the original order of statements filled by the user, so that all set statements are moved to the beginning and the middle set statement is not executed in its original position.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] wolfboys merged pull request #1826: [bug] [fix] [streampark-flink-shims-base] Repair multiple dialect set statement have no effect error.

Posted by GitBox <gi...@apache.org>.
wolfboys merged PR #1826:
URL: https://github.com/apache/incubator-streampark/pull/1826


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] wolfboys commented on pull request #1826: [bug] [fix] [streampark-flink-shims-base] Repair multiple dialect set statement have no effect error.

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #1826:
URL: https://github.com/apache/incubator-streampark/pull/1826#issuecomment-1277416897

   Thanks for your contribution, There are still bugs in the actual test. keep going


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] lvshaokang commented on pull request #1826: [bug] [fix] [streampark-flink-shims-base] Repair multiple dialect set statement have no effect error.

Posted by GitBox <gi...@apache.org>.
lvshaokang commented on PR #1826:
URL: https://github.com/apache/incubator-streampark/pull/1826#issuecomment-1276248080

   Hi, @ziqiang-wang. Thanks for you feedback.
   Please follow the PR template to describe the changes contributed by the pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] ziqiang-wang commented on pull request #1826: [bug] [fix] [streampark-flink-shims-base] Repair multiple dialect set statement have no effect error.

Posted by GitBox <gi...@apache.org>.
ziqiang-wang commented on PR #1826:
URL: https://github.com/apache/incubator-streampark/pull/1826#issuecomment-1276991700

   ## change
   Issue Number: close #1702 
   
   Repair multiple dialect set statement have no effect error.
   
   Cause:
   The sql statement sorts the results at the end of the parseSQL function, disrupting the original order of statements filled by the user, so that all set statements are moved to the beginning and the middle set statement is not executed in its original position.
   
   ![image](https://user-images.githubusercontent.com/107013241/195495017-2b07bf69-8448-4089-ba41-20a18fe8d57c.png)
   
   
   ## Verifying this change
   
   Only test in idea debug, also need to test the product environment.
   
   
   Dependencies : no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] ziqiang-wang commented on pull request #1826: [bug] [fix] [streampark-flink-shims-base] Repair multiple dialect set statement have no effect error.

Posted by GitBox <gi...@apache.org>.
ziqiang-wang commented on PR #1826:
URL: https://github.com/apache/incubator-streampark/pull/1826#issuecomment-1276992261

   ## change
   Issue Number: close #1702
   
   Repair multiple dialect set statement have no effect error.
   
   Cause:
   The sql statement sorts the results at the end of the parseSQL function, disrupting the original order of statements filled by the user, so that all set statements are moved to the beginning and the middle set statement is not executed in its original position.
   
   ![image](https://user-images.githubusercontent.com/107013241/195495181-5f5d9158-2f73-481b-87d6-201b7d230342.png)
   
   
   ## Verifying this change
   
   Only test in idea debug, also need to test the product environment.
   
   ## dependencies
   Dependencies : no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-streampark] ziqiang-wang commented on pull request #1826: [bug] [fix] [streampark-flink-shims-base] Repair multiple dialect set statement have no effect error.

Posted by GitBox <gi...@apache.org>.
ziqiang-wang commented on PR #1826:
URL: https://github.com/apache/incubator-streampark/pull/1826#issuecomment-1289076576

   The latest pr submission:
   
   1. Fixed an issue where hive sql could not be run due to the platform changing the flink sql order, which could not load hive dialect correctly.
   2. Fix the problem that resources of the flink job manager role are not automatically released after the flink sql batch task is successfully run in yarn per job mode.
   3. Remove the validity check for keys in the set statement, because the platform is not yet able to aggregate all keys
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org