You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "hadrian-reppas (via GitHub)" <gi...@apache.org> on 2025/06/24 20:15:10 UTC

[I] [Docs][Python][C++] Asof join documentation is wrong/incomplete [arrow]

hadrian-reppas opened a new issue, #46897:
URL: https://github.com/apache/arrow/issues/46897

   ### Describe the bug, including details regarding any error messages, version, and platform.
   
   There are two issues with the asof join docs:
   1. In the doc for the `on` parameter, it says "a row is considered a match if and only if left_on - tolerance <= right_on <= left_on." This is incorrect because a join with positive tolerance results in right_on values that are _greater_ than or equal to left_on. Also, the inequality does not make sense for negative tolerances.
   2. In the doc for the `tolerance` parameter, it says "A right row is considered a match with the left row `right.on - left.on <= tolerance`." This does not mention that the difference must also be greater than or equal to 0. Also, the inequality is only correct for non-negative `tolerance`s.
   
   ### Component(s)
   
   Python


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs][Python][C++] Asof join documentation is wrong/incomplete [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 closed issue #46897: [Docs][Python][C++] Asof join documentation is wrong/incomplete
URL: https://github.com/apache/arrow/issues/46897


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Docs][Python][C++] Asof join documentation is wrong/incomplete [arrow]

Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on issue #46897:
URL: https://github.com/apache/arrow/issues/46897#issuecomment-3047172921

   Issue resolved by pull request 46898
   https://github.com/apache/arrow/pull/46898


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org