You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Ian Cook (Jira)" <ji...@apache.org> on 2021/08/04 18:38:00 UTC

[jira] [Updated] (ARROW-13561) [C++] Implement week kernel that accepts DayOfWeekOptions

     [ https://issues.apache.org/jira/browse/ARROW-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ian Cook updated ARROW-13561:
-----------------------------
    Description: 
Arrow has an {{iso_week}} compute kernel that follows the [ISO 8601 week date definition|https://en.wikipedia.org/wiki/ISO_week_date#First_week]. Add another kernel (maybe named {{week}}) that lets you specify options for how exactly to count weeks, like MySQL's week function: [https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_week|https://www.google.com/url?q=https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html%23function_week&sa=D&source=editors&ust=1628103672101000&usg=AFQjCNHap0KtiiZ83G_PVRPz5T7z6y-lIQ].

I think we can reuse the existing {{DayOfWeekOptions}} to specify the options, but we should change the description of the {{one_based_numbering}} argument to:
{quote}Number from 1 if true and from 0 if false.
{quote}
removing the word "days" from it, so it can control whether days _or_ weeks are numbered starting from 0 or 1 depending on where it's used.

  was:Arrow has an {{iso_week}} compute kernel that follows the [ISO 8601 week date definition|https://en.wikipedia.org/wiki/ISO_week_date#First_week]. Add another kernel (maybe named {{week}}) that lets you specify options for how exactly to count weeks, like MySQL's week function: [https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_week|https://www.google.com/url?q=https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html%23function_week&sa=D&source=editors&ust=1628103672101000&usg=AFQjCNHap0KtiiZ83G_PVRPz5T7z6y-lIQ]. I think we can reuse the existing {{DayOfWeekOptions}} to specify the options.


> [C++] Implement week kernel that accepts DayOfWeekOptions
> ---------------------------------------------------------
>
>                 Key: ARROW-13561
>                 URL: https://issues.apache.org/jira/browse/ARROW-13561
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Ian Cook
>            Priority: Major
>
> Arrow has an {{iso_week}} compute kernel that follows the [ISO 8601 week date definition|https://en.wikipedia.org/wiki/ISO_week_date#First_week]. Add another kernel (maybe named {{week}}) that lets you specify options for how exactly to count weeks, like MySQL's week function: [https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html#function_week|https://www.google.com/url?q=https://dev.mysql.com/doc/refman/8.0/en/date-and-time-functions.html%23function_week&sa=D&source=editors&ust=1628103672101000&usg=AFQjCNHap0KtiiZ83G_PVRPz5T7z6y-lIQ].
> I think we can reuse the existing {{DayOfWeekOptions}} to specify the options, but we should change the description of the {{one_based_numbering}} argument to:
> {quote}Number from 1 if true and from 0 if false.
> {quote}
> removing the word "days" from it, so it can control whether days _or_ weeks are numbered starting from 0 or 1 depending on where it's used.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)