(datafusion) branch main updated: bench: remove stale `array_expression` benchmark (#22143)

[gi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git


The following commit(s) were added to refs/heads/main by this push:
     new 6a57b22084 bench: remove stale `array_expression` benchmark (#22143)
6a57b22084 is described below

commit 6a57b220842f342e3765912f5e64c299f9756529
Author: Kumar Ujjawal <uj...@gmail.com>
AuthorDate: Fri May 15 00:30:48 2026 +0530

    bench: remove stale `array_expression` benchmark (#22143)
    
    ## Which issue does this PR close?
    
    <!--
    We generally require a GitHub issue to be filed for all bug fixes and
    enhancements and this helps us generate change logs for our releases.
    You can link an issue to this PR using the GitHub syntax. For example
    `Closes #123` indicates that this PR will close issue #123.
    -->
    
    - Closes #22121
    
    ## Rationale for this change
    
    `array_replace.rs` already covers `array_replace`, `array_replace_n`,
    and `array_replace_all` through the public UDF path, and includes the
    relevant int64 benchmark sizes plus broader nested, string, boolean, and
    fixed-size-binary cases.
    
    Keeping both benchmark targets would duplicate maintenance and make
    ownership unclear.
    
    <!--
    Why are you proposing this change? If this is already explained clearly
    in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand
    your changes and offer better suggestions for fixes.
    -->
    
    ## What changes are included in this PR?
    
    This removes the stale `array_expression` benchmark target.
    
    The dedicated `array_replace` benchmark remains the single benchmark
    owner for array replacement performance.
    
    <!--
    There is no need to duplicate the description in the issue here but it
    is sometimes worth providing a summary of the individual changes in this
    PR.
    -->
    
    ## Are these changes tested?
    
    Yes, locally
    
    <!--
    We typically require tests for all PRs in order to:
    1. Prevent the code from being accidentally broken by subsequent changes
    2. Serve as another way to document the expected behavior of the code
    
    If tests are not included in your PR, please explain why (for example,
    are they covered by existing tests)?
    -->
    
    ## Are there any user-facing changes?
    
    No
    
    <!--
    If there are user-facing changes then we may require documentation to be
    updated before approving the PR.
    -->
    
    <!--
    If there are any breaking changes to public APIs, please add the `api
    change` label.
    -->
---
 datafusion/functions-nested/Cargo.toml             |  4 --
 .../functions-nested/benches/array_expression.rs   | 47 ----------------------
 2 files changed, 51 deletions(-)

diff --git a/datafusion/functions-nested/Cargo.toml b/datafusion/functions-nested/Cargo.toml
index 83bed152f6..ed5a89b8e3 100644
--- a/datafusion/functions-nested/Cargo.toml
+++ b/datafusion/functions-nested/Cargo.toml
@@ -78,10 +78,6 @@ name = "array_concat"
 harness = false
 name = "array_min_max"
 
-[[bench]]
-harness = false
-name = "array_expression"
-
 [[bench]]
 harness = false
 name = "arrays_zip"
diff --git a/datafusion/functions-nested/benches/array_expression.rs b/datafusion/functions-nested/benches/array_expression.rs
deleted file mode 100644
index 71bb939238..0000000000
--- a/datafusion/functions-nested/benches/array_expression.rs
+++ /dev/null
@@ -1,47 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
-// or more contributor license agreements.  See the NOTICE file
-// distributed with this work for additional information
-// regarding copyright ownership.  The ASF licenses this file
-// to you under the Apache License, Version 2.0 (the
-// "License"); you may not use this file except in compliance
-// with the License.  You may obtain a copy of the License at
-//
-//   http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing,
-// software distributed under the License is distributed on an
-// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-// KIND, either express or implied.  See the License for the
-// specific language governing permissions and limitations
-// under the License.
-
-use criterion::{Criterion, criterion_group, criterion_main};
-use datafusion_expr::lit;
-use datafusion_functions_nested::expr_fn::{array_replace_all, make_array};
-use std::hint::black_box;
-
-fn criterion_benchmark(c: &mut Criterion) {
-    // Construct large arrays for benchmarking
-
-    let array_len = 100_000;
-
-    let array = (0..array_len).map(|_| lit(2_i64)).collect::<Vec<_>>();
-    let list_array = make_array(vec![make_array(array); 3]);
-    let from_array = make_array(vec![lit(2_i64); 3]);
-    let to_array = make_array(vec![lit(-2_i64); 3]);
-
-    // Benchmark array functions
-
-    c.bench_function("array_replace", |b| {
-        b.iter(|| {
-            black_box(array_replace_all(
-                list_array.clone(),
-                from_array.clone(),
-                to_array.clone(),
-            ))
-        })
-    });
-}
-
-criterion_group!(benches, criterion_benchmark);
-criterion_main!(benches);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org