[jira] [Created] (YARN-5834) TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time to the incorrect value

["Miklos Szegedi (JIRA)" <ji...@apache.org>]

Miklos Szegedi created YARN-5834:
------------------------------------

             Summary: TestNodeStatusUpdater.testNMRMConnectionConf compares nodemanager wait time to the incorrect value
                 Key: YARN-5834
                 URL: https://issues.apache.org/jira/browse/YARN-5834
             Project: Hadoop YARN
          Issue Type: Bug
            Reporter: Miklos Szegedi
            Priority: Minor


The function is TestNodeStatusUpdater#testNMRMConnectionConf()
I believe the connectionWaitMs references below were meant to be nmRmConnectionWaitMs.
{code}
    conf.setLong(YarnConfiguration.NM_RESOURCEMANAGER_CONNECT_MAX_WAIT_MS,
        nmRmConnectionWaitMs);
conf.setLong(YarnConfiguration.RESOURCEMANAGER_CONNECT_MAX_WAIT_MS,
        connectionWaitMs);
...
      long t = System.currentTimeMillis();
      long duration = t - waitStartTime;
      boolean waitTimeValid = (duration >= nmRmConnectionWaitMs) &&
          (duration < (*connectionWaitMs* + delta));

      if(!waitTimeValid) {
        // throw exception if NM doesn't retry long enough
        throw new Exception("NM should have tried re-connecting to RM during " +
          "period of at least " + *connectionWaitMs* + " ms, but " +
          "stopped retrying within " + (*connectionWaitMs* + delta) +
          " ms: " + e, e);
      }
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org