You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/27 13:53:00 UTC
[jira] [Commented] (AIRFLOW-3576) Remove unnecessray arg 'root' in
url_for("airflow.delete", dag_id=dag.dag_id, root=root)
[ https://issues.apache.org/jira/browse/AIRFLOW-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729616#comment-16729616 ]
ASF GitHub Bot commented on AIRFLOW-3576:
-----------------------------------------
XD-DENG commented on pull request #4380: [AIRFLOW-3576] Remove unnecessray arg 'root' for /delete in dag.html
URL: https://github.com/apache/incubator-airflow/pull/4380
### Jira
https://issues.apache.org/jira/browse/AIRFLOW-3576
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
In `airflow/www/templates/airflow/dag.html` or `airflow/www_rbac/templates/airflow/dag.html`, in line `<a href="{{ url_for("airflow.delete", dag_id=dag.dag_id, root=root) }}"`, `root` is not necessary, given it's not used anywhere in the `'/delete'` method in either `airflow/www/views.py` or `airflow/www_rbac/views.py`.
**Please correct me if I'm incorrect about this or missed anything.**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Remove unnecessray arg 'root' in url_for("airflow.delete", dag_id=dag.dag_id, root=root)
> ----------------------------------------------------------------------------------------
>
> Key: AIRFLOW-3576
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3576
> Project: Apache Airflow
> Issue Type: Improvement
> Reporter: Xiaodong DENG
> Assignee: Xiaodong DENG
> Priority: Major
>
> In airflow/www/templates/airflow/dag.html or airflow/www_rbac/templates/airflow/dag.html, in line *<a href="{{ url_for("airflow.delete", dag_id=dag.dag_id, root=root) }}**"*, *root* is not necessary, given it's not used anywhere in the '/delete' method in either *airflow/www/views.py* or *airflow/www_rbac/views.py*.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)