You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ag...@apache.org on 2022/05/11 02:30:55 UTC
[arrow-datafusion] branch master updated: MINOR: Add ignored tests for all remaining benchmark queries (#2506)
This is an automated email from the ASF dual-hosted git repository.
agrove pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git
The following commit(s) were added to refs/heads/master by this push:
new 7d66aed6a MINOR: Add ignored tests for all remaining benchmark queries (#2506)
7d66aed6a is described below
commit 7d66aed6a1120da1b6fdfba4ccccde080a2b0f39
Author: Andy Grove <ag...@apache.org>
AuthorDate: Tue May 10 20:30:51 2022 -0600
MINOR: Add ignored tests for all remaining benchmark queries (#2506)
---
benchmarks/src/bin/tpch.rs | 48 ++++++++++++++++++++++
.../physical-expr/src/expressions/datetime.rs | 13 +++++-
2 files changed, 60 insertions(+), 1 deletion(-)
diff --git a/benchmarks/src/bin/tpch.rs b/benchmarks/src/bin/tpch.rs
index 15b7f987a..d87a9c042 100644
--- a/benchmarks/src/bin/tpch.rs
+++ b/benchmarks/src/bin/tpch.rs
@@ -1024,11 +1024,23 @@ mod tests {
run_query(1).await
}
+ #[ignore] // https://github.com/apache/arrow-datafusion/issues/159
+ #[tokio::test]
+ async fn run_2() -> Result<()> {
+ run_query(2).await
+ }
+
#[tokio::test]
async fn run_q3() -> Result<()> {
run_query(3).await
}
+ #[ignore] // https://github.com/apache/arrow-datafusion/issues/160
+ #[tokio::test]
+ async fn run_q4() -> Result<()> {
+ run_query(4).await
+ }
+
#[tokio::test]
async fn run_q5() -> Result<()> {
run_query(5).await
@@ -1059,6 +1071,12 @@ mod tests {
run_query(10).await
}
+ #[ignore] // https://github.com/apache/arrow-datafusion/issues/163
+ #[tokio::test]
+ async fn run_q11() -> Result<()> {
+ run_query(11).await
+ }
+
#[tokio::test]
async fn run_q12() -> Result<()> {
run_query(12).await
@@ -1074,11 +1092,23 @@ mod tests {
run_query(14).await
}
+ #[ignore] // https://github.com/apache/arrow-datafusion/issues/166
+ #[tokio::test]
+ async fn run_q15() -> Result<()> {
+ run_query(15).await
+ }
+
#[tokio::test]
async fn run_q16() -> Result<()> {
run_query(16).await
}
+ #[ignore] // https://github.com/apache/arrow-datafusion/issues/168
+ #[tokio::test]
+ async fn run_q17() -> Result<()> {
+ run_query(17).await
+ }
+
#[tokio::test]
async fn run_q18() -> Result<()> {
run_query(18).await
@@ -1089,6 +1119,24 @@ mod tests {
run_query(19).await
}
+ #[ignore] // https://github.com/apache/arrow-datafusion/issues/171
+ #[tokio::test]
+ async fn run_q20() -> Result<()> {
+ run_query(20).await
+ }
+
+ #[ignore] // https://github.com/apache/arrow-datafusion/issues/172
+ #[tokio::test]
+ async fn run_q21() -> Result<()> {
+ run_query(21).await
+ }
+
+ #[ignore] // https://github.com/apache/arrow-datafusion/issues/175
+ #[tokio::test]
+ async fn run_q22() -> Result<()> {
+ run_query(22).await
+ }
+
/// Specialised String representation
fn col_str(column: &ArrayRef, row_index: usize) -> String {
if column.is_null(row_index) {
diff --git a/datafusion/physical-expr/src/expressions/datetime.rs b/datafusion/physical-expr/src/expressions/datetime.rs
index df186121a..3d84e79f2 100644
--- a/datafusion/physical-expr/src/expressions/datetime.rs
+++ b/datafusion/physical-expr/src/expressions/datetime.rs
@@ -89,9 +89,20 @@ impl PhysicalExpr for DateIntervalExpr {
let interval = match intervals {
ColumnarValue::Scalar(interval) => match interval {
ScalarValue::IntervalDayTime(Some(interval)) => interval as i32,
+ ScalarValue::IntervalYearMonth(Some(_)) => {
+ return Err(DataFusionError::Execution(
+ "DateIntervalExpr does not support IntervalYearMonth".to_string(),
+ ))
+ }
+ ScalarValue::IntervalMonthDayNano(Some(_)) => {
+ return Err(DataFusionError::Execution(
+ "DateIntervalExpr does not support IntervalMonthDayNano"
+ .to_string(),
+ ))
+ }
other => {
return Err(DataFusionError::Execution(format!(
- "DateIntervalExpr does not support interval {}",
+ "DateIntervalExpr does not support non-interval type {:?}",
other
)))
}