[jira] [Created] (LOG4J2-3618) Multiple PropertySources with identical priority cannot be added to PropertiesUtil Environment

["Phillip Webb (Jira)" <ji...@apache.org>]

Phillip Webb created LOG4J2-3618:
------------------------------------

             Summary: Multiple PropertySources with identical priority cannot be added to PropertiesUtil Environment
                 Key: LOG4J2-3618
                 URL: https://issues.apache.org/jira/browse/LOG4J2-3618
             Project: Log4j 2
          Issue Type: Bug
          Components: Core
    Affects Versions: 2.17.2
            Reporter: Phillip Webb


The {{org.apache.logging.log4j.util.PropertiesUtil.Environment}} maintains a set of {{sources}} by using a {{ConcurrentSkipListSet}} backed with a {{PropertySource.Comparator}}.

Somewhat surprisingly, the {{ConcurrentSkipListSet}} will not add an item if comparing it to an existing one returns {{0}}. This means that all {{PropertySource}} implementations must have unique {{getPriority()}} results. I think this might be better to use a {{Set}} that uses {{equals/hashCode}} to determine if items can be added and only use the {{Comparator}} for sorting.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)