You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/05/23 23:09:01 UTC
Review Request: A few webui additions/updates. In particular: added a
loading graphic and only update the DOM if the state received from the
master has changed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5208/
-----------------------------------------------------------
Review request for mesos, John Sirois, Vinod Kone, and Jonathan Fuchs.
Summary
-------
See summary.
Diffs
-----
src/master/master.cpp 09c2e03
src/webui/master/static/app.js 2991ddf
src/webui/master/static/controllers.js e48ae24
src/webui/master/static/framework.html 8b8a869
src/webui/master/static/frameworks.html 0cc6fc0
src/webui/master/static/home.html 6b85042
src/webui/master/static/index.html d7cf14e
src/webui/master/static/loading.gif PRE-CREATION
src/webui/master/static/log.html 503b6b4
src/webui/master/static/popovers.js 06de343
src/webui/master/static/slaves.html 0ced189
Diff: https://reviews.apache.org/r/5208/diff
Testing
-------
Thanks,
Benjamin
Re: Review Request: A few webui additions/updates. In particular: added a
loading graphic and only update the DOM if the state received from the
master has changed.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2012-05-24 04:43:41, Jonathan Fuchs wrote:
> >
Thanks Jon, submitted.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5208/#review8076
-----------------------------------------------------------
On 2012-05-23 21:34:16, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5208/
> -----------------------------------------------------------
>
> (Updated 2012-05-23 21:34:16)
>
>
> Review request for mesos, John Sirois, Vinod Kone, and Jonathan Fuchs.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp 09c2e03
> src/webui/master/static/app.js 2991ddf
> src/webui/master/static/controllers.js e48ae24
> src/webui/master/static/framework.html 8b8a869
> src/webui/master/static/frameworks.html 0cc6fc0
> src/webui/master/static/home.html 6b85042
> src/webui/master/static/index.html d7cf14e
> src/webui/master/static/loading.gif PRE-CREATION
> src/webui/master/static/log.html 503b6b4
> src/webui/master/static/popovers.js 06de343
> src/webui/master/static/slaves.html 0ced189
>
> Diff: https://reviews.apache.org/r/5208/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: A few webui additions/updates. In particular: added a
loading graphic and only update the DOM if the state received from the
master has changed.
Posted by Jonathan Fuchs <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5208/#review8076
-----------------------------------------------------------
Ship it!
- Jonathan
On 2012-05-23 21:34:16, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5208/
> -----------------------------------------------------------
>
> (Updated 2012-05-23 21:34:16)
>
>
> Review request for mesos, John Sirois, Vinod Kone, and Jonathan Fuchs.
>
>
> Summary
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp 09c2e03
> src/webui/master/static/app.js 2991ddf
> src/webui/master/static/controllers.js e48ae24
> src/webui/master/static/framework.html 8b8a869
> src/webui/master/static/frameworks.html 0cc6fc0
> src/webui/master/static/home.html 6b85042
> src/webui/master/static/index.html d7cf14e
> src/webui/master/static/loading.gif PRE-CREATION
> src/webui/master/static/log.html 503b6b4
> src/webui/master/static/popovers.js 06de343
> src/webui/master/static/slaves.html 0ced189
>
> Diff: https://reviews.apache.org/r/5208/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin
>
>
Re: Review Request: A few webui additions/updates. In particular: added a
loading graphic and only update the DOM if the state received from the
master has changed.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5208/
-----------------------------------------------------------
(Updated 2012-05-23 21:34:16.602819)
Review request for mesos, John Sirois, Vinod Kone, and Jonathan Fuchs.
Changes
-------
A few cleanups based on my review of the diff.
Summary
-------
See summary.
Diffs (updated)
-----
src/master/master.cpp 09c2e03
src/webui/master/static/app.js 2991ddf
src/webui/master/static/controllers.js e48ae24
src/webui/master/static/framework.html 8b8a869
src/webui/master/static/frameworks.html 0cc6fc0
src/webui/master/static/home.html 6b85042
src/webui/master/static/index.html d7cf14e
src/webui/master/static/loading.gif PRE-CREATION
src/webui/master/static/log.html 503b6b4
src/webui/master/static/popovers.js 06de343
src/webui/master/static/slaves.html 0ced189
Diff: https://reviews.apache.org/r/5208/diff
Testing
-------
Thanks,
Benjamin