[GitHub] [incubator-shardingsphere] terrymanu commented on issue #2523: try commit a startup boosted mode and default set to false

[GitBox <gi...@apache.org>]

terrymanu commented on issue #2523: try commit a startup boosted mode and default set to false
URL: https://github.com/apache/incubator-shardingsphere/pull/2523#issuecomment-500125006
 
 
   Hi, ref with #2522, the problems are still existed.
   
   1. Travis still broken. Right now, although the travis are not broken because of you create a new boolean to switch off your new codes. If the boolean value is switch on, I think the travis still broken. Can you add test cases for your new codes?
   2. The problem is still existed for unlimited threads cause resources exhausted if the boolean value is switch on.
   3. The problem is still existed for refresh databases of orchestration module if boolean value is switch on.
   4. `System.out.print` are not permitted.
   5. We don't prefer include a temporary design for test mode only, we need to prove the new design are good enough for production code. 
   
   If you just test in your own environment, all changes are fine if you think it is ok. 
   But if you want merge your pr to master, could you solve the problems above?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services