You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by herval <gi...@git.apache.org> on 2017/06/26 20:59:26 UTC
[GitHub] zeppelin pull request #2440: [ZEPPELIN-2587] allow logging in if youre anony...
GitHub user herval opened a pull request:
https://github.com/apache/zeppelin/pull/2440
[ZEPPELIN-2587] allow logging in if youre anonymous
### What is this PR for?
The login button is not showing (since 0.7.1) if you allow anonymous access. This shows it again.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN/ZEPPELIN-2587
### How should this be tested?
- Start Zeppelin with anonymous support
- The login button should now show on the bar
### Questions:
* Does the licenses files need update?
No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/herval/zeppelin allow-login
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2440.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2440
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous
Posted by herval <gi...@git.apache.org>.
Github user herval commented on the issue:
https://github.com/apache/zeppelin/pull/2440
hmm I'm finding it difficult to get all the integration tests to pass. Inclined to test only for the presence of the button.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2440
@1ambda can you check this issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous
Posted by herval <gi...@git.apache.org>.
Github user herval commented on the issue:
https://github.com/apache/zeppelin/pull/2440
Hi folks,
Please let me know if I should close this. Tks!
---
[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2440
Could we add a simple selenium test for this ? Regression issue is bad thing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous
Posted by herval <gi...@git.apache.org>.
Github user herval commented on the issue:
https://github.com/apache/zeppelin/pull/2440
any additional thoughts on this? Is it mergeable? @jongyoul @cfries
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2440: [ZEPPELIN-2587] allow logging in if you're anon...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2440
---
[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2440
@herval
1. Could you rebase? base branch is quite old
2. We need to pass CI. Please the failed tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2440
I don't know the purpose of this PR. If username is anonymous, it means shiro is off. What's your intention?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous
Posted by herval <gi...@git.apache.org>.
Github user herval commented on the issue:
https://github.com/apache/zeppelin/pull/2440
@zjffdu added one, let me know if that covers it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous
Posted by herval <gi...@git.apache.org>.
Github user herval commented on the issue:
https://github.com/apache/zeppelin/pull/2440
This is now passing all tests - please advise
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous
Posted by cfries <gi...@git.apache.org>.
Github user cfries commented on the issue:
https://github.com/apache/zeppelin/pull/2440
Hi @jongyoul : I don't understand your comment. You can have "anonymous" when shirt is on. This is even in the shiro example (note: If I understood the shiro example correctly: until the user is not logged in, he is "anonymous" and hence the login page is allowed for "anonymous").
The issue https://issues.apache.org/jira/browse/ZEPPELIN-2587 is real, but I have not yet checked if this PR fixes it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2440
I got it. I didn't recognize actual username is "anonymous" in production case. If it can be, it will be a problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---