You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/17 18:38:41 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request #314: return reference from DictionaryArray::values() (#313)
tustvold opened a new pull request #314:
URL: https://github.com/apache/arrow-rs/pull/314
# Which issue does this PR close?
Closes #313.
# Rationale for this change
See ticket, but in short it allows borrow lifetimes to correctly propagate without creating issues around stack-local temporaries
# Are there any user-facing changes?
As currently formulated this is a breaking change, but it could easily be reworked to not be if preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #314: return reference from DictionaryArray::values() (#313)
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #314:
URL: https://github.com/apache/arrow-rs/pull/314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #314: return reference from DictionaryArray::values() (#313)
Posted by GitBox <gi...@apache.org>.
tustvold commented on pull request #314:
URL: https://github.com/apache/arrow-rs/pull/314#issuecomment-842524316
@jorgecarleitao Rebased to fix accidental formatting change, you were faster than anticipated :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #314: return reference from DictionaryArray::values() (#313)
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #314:
URL: https://github.com/apache/arrow-rs/pull/314#issuecomment-842664028
This is probably technically a "breaking" change as some code that used to compile will no longer...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] jhorstmann commented on pull request #314: return reference from DictionaryArray::values() (#313)
Posted by GitBox <gi...@apache.org>.
jhorstmann commented on pull request #314:
URL: https://github.com/apache/arrow-rs/pull/314#issuecomment-843005564
Nice! While we're looking at the DictionaryArray and introducing api changes, we should also remove the `keys_array` method since the same functionality is now provided by the `keys` method. The `keys_array` has measurable overhead when used in inner loops also due to clones. Some time ago, `keys` only returned an iterator and `keys_array` had its uses, but now it's fully redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org