You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "dhruba borthakur (JIRA)" <ji...@apache.org> on 2009/03/12 07:18:50 UTC
[jira] Created: (HADOOP-5472) Distcp does not support globbing of
input paths
Distcp does not support globbing of input paths
-----------------------------------------------
Key: HADOOP-5472
URL: https://issues.apache.org/jira/browse/HADOOP-5472
Project: Hadoop Core
Issue Type: Bug
Components: tools/distcp
Reporter: dhruba borthakur
Assignee: dhruba borthakur
Fix For: 0.20.0
The current version of distcp does not support globbing of input paths.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5472) Distcp does not support globbing of
input paths
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-5472:
------------------------------------
Fix Version/s: 0.21.0
Status: Patch Available (was: Open)
> Distcp does not support globbing of input paths
> -----------------------------------------------
>
> Key: HADOOP-5472
> URL: https://issues.apache.org/jira/browse/HADOOP-5472
> Project: Hadoop Core
> Issue Type: Bug
> Components: tools/distcp
> Reporter: dhruba borthakur
> Assignee: Rodrigo Schmidt
> Fix For: 0.21.0
>
> Attachments: DistcpGlob.txt, HADOOP-5427.patch
>
>
> The current version of distcp does not support globbing of input paths.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5472) Distcp does not support globbing of
input paths
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700321#action_12700321 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-5472:
------------------------------------------------
It seems that fs.globStatus(p) will not return null. If p does not exist, it returns an empty array. So, we only have to check whether inputs.length > 0. If inputs.length > 0, add all paths to the list. If inputs.length == 0, add an IOException to rslt (we don't have to check !fs.exists(p) again).
Also, could you add a test?
> Distcp does not support globbing of input paths
> -----------------------------------------------
>
> Key: HADOOP-5472
> URL: https://issues.apache.org/jira/browse/HADOOP-5472
> Project: Hadoop Core
> Issue Type: Bug
> Components: tools/distcp
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.20.0
>
> Attachments: DistcpGlob.txt
>
>
> The current version of distcp does not support globbing of input paths.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5472) Distcp does not support globbing of
input paths
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713149#action_12713149 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-5472:
------------------------------------------------
+1 patch looks good.
> Distcp does not support globbing of input paths
> -----------------------------------------------
>
> Key: HADOOP-5472
> URL: https://issues.apache.org/jira/browse/HADOOP-5472
> Project: Hadoop Core
> Issue Type: Bug
> Components: tools/distcp
> Reporter: dhruba borthakur
> Assignee: Rodrigo Schmidt
> Fix For: 0.21.0
>
> Attachments: DistcpGlob.txt, HADOOP-5427.patch
>
>
> The current version of distcp does not support globbing of input paths.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5472) Distcp does not support globbing of
input paths
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur reassigned HADOOP-5472:
----------------------------------------
Assignee: Rodrigo Schmidt (was: dhruba borthakur)
> Distcp does not support globbing of input paths
> -----------------------------------------------
>
> Key: HADOOP-5472
> URL: https://issues.apache.org/jira/browse/HADOOP-5472
> Project: Hadoop Core
> Issue Type: Bug
> Components: tools/distcp
> Reporter: dhruba borthakur
> Assignee: Rodrigo Schmidt
> Attachments: DistcpGlob.txt
>
>
> The current version of distcp does not support globbing of input paths.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5472) Distcp does not support globbing of
input paths
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711817#action_12711817 ]
Rodrigo Schmidt commented on HADOOP-5472:
-----------------------------------------
An ArrayList might not be the best data structure to unglob the input sources, as the internal array will be re-sized for every new entry we add. A LinkedList would fit better.
> Distcp does not support globbing of input paths
> -----------------------------------------------
>
> Key: HADOOP-5472
> URL: https://issues.apache.org/jira/browse/HADOOP-5472
> Project: Hadoop Core
> Issue Type: Bug
> Components: tools/distcp
> Reporter: dhruba borthakur
> Assignee: Rodrigo Schmidt
> Attachments: DistcpGlob.txt
>
>
> The current version of distcp does not support globbing of input paths.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5472) Distcp does not support globbing of
input paths
Posted by "dhruba borthakur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HADOOP-5472:
-------------------------------------
Attachment: DistcpGlob.txt
Glob the input paths passed to the DistCp command.
> Distcp does not support globbing of input paths
> -----------------------------------------------
>
> Key: HADOOP-5472
> URL: https://issues.apache.org/jira/browse/HADOOP-5472
> Project: Hadoop Core
> Issue Type: Bug
> Components: tools/distcp
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Fix For: 0.20.0
>
> Attachments: DistcpGlob.txt
>
>
> The current version of distcp does not support globbing of input paths.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5472) Distcp does not support globbing of
input paths
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712611#action_12712611 ]
Hadoop QA commented on HADOOP-5472:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12408749/HADOOP-5427.patch
against trunk revision 778182.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/393/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/393/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/393/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/393/console
This message is automatically generated.
> Distcp does not support globbing of input paths
> -----------------------------------------------
>
> Key: HADOOP-5472
> URL: https://issues.apache.org/jira/browse/HADOOP-5472
> Project: Hadoop Core
> Issue Type: Bug
> Components: tools/distcp
> Reporter: dhruba borthakur
> Assignee: Rodrigo Schmidt
> Fix For: 0.21.0
>
> Attachments: DistcpGlob.txt, HADOOP-5427.patch
>
>
> The current version of distcp does not support globbing of input paths.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5472) Distcp does not support globbing of
input paths
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5472:
-------------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I have committed this. Thanks, Dhruba Borthakur and Rodrigo Schmidt!
> Distcp does not support globbing of input paths
> -----------------------------------------------
>
> Key: HADOOP-5472
> URL: https://issues.apache.org/jira/browse/HADOOP-5472
> Project: Hadoop Core
> Issue Type: Bug
> Components: tools/distcp
> Reporter: dhruba borthakur
> Assignee: Rodrigo Schmidt
> Fix For: 0.21.0
>
> Attachments: DistcpGlob.txt, HADOOP-5427.patch
>
>
> The current version of distcp does not support globbing of input paths.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5472) Distcp does not support globbing of
input paths
Posted by "Rodrigo Schmidt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rodrigo Schmidt updated HADOOP-5472:
------------------------------------
Attachment: HADOOP-5427.patch
> Distcp does not support globbing of input paths
> -----------------------------------------------
>
> Key: HADOOP-5472
> URL: https://issues.apache.org/jira/browse/HADOOP-5472
> Project: Hadoop Core
> Issue Type: Bug
> Components: tools/distcp
> Reporter: dhruba borthakur
> Assignee: Rodrigo Schmidt
> Fix For: 0.21.0
>
> Attachments: DistcpGlob.txt, HADOOP-5427.patch
>
>
> The current version of distcp does not support globbing of input paths.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.