You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by ssharma555 <gi...@git.apache.org> on 2018/06/29 10:21:06 UTC
[GitHub] zeppelin pull request #3045: ZEPPELIN-3570. Fix for doing user search for LD...
GitHub user ssharma555 opened a pull request:
https://github.com/apache/zeppelin/pull/3045
ZEPPELIN-3570. Fix for doing user search for LDAPRealm
### What is this PR for?
To enable user search for LdapRealm.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3570
### How should this be tested?
For the below config
```
[main]
ldapRealm = org.apache.zeppelin.realm.LdapRealm
ldapRealm.userDnTemplate = cn={0},ou=Users,dc=company,dc=com
ldapRealm.contextFactory.url = ldap://<ldap-server-host>:389
ldapRealm.contextFactory.authenticationMechanism = SIMPLE
ldapRealm.searchBase = dc=company,dc=com
ldapRealm.userSearchBase = dc=company,dc=com
ldapRealm.groupSearchBase = dc=company,dc=com
ldapRealm.userSearchAttributeName = uid
sessionManager = org.apache.shiro.web.session.mgt.DefaultWebSessionManager
securityManager.sessionManager = $sessionManager
securityManager.sessionManager.globalSessionTimeout = 86400000
shiro.loginUrl = /api/login
[urls]
/api/version = anon
/** = authc
```
user search in notebook/interpreter should work for partial string.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ssharma555/zeppelin ZEPPELIN-3570
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3045.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3045
----
commit 114c7e4baaca839252123bf55d8cc0618cd1fa69
Author: Supreeth Sharma <ss...@...>
Date: 2018-06-29T10:05:48Z
ZEPPELIN-3570. Fix for doing user search for LDAPRealm
----
---
[GitHub] zeppelin issue #3045: ZEPPELIN-3570. Fix for doing user search for LDAPRealm
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3045
Merging this to master and branch-0.8 if no more discussion.
---
[GitHub] zeppelin issue #3045: ZEPPELIN-3570. Fix for doing user search for LDAPRealm
Posted by ssharma555 <gi...@git.apache.org>.
Github user ssharma555 commented on the issue:
https://github.com/apache/zeppelin/pull/3045
@prabhjyotsingh @felixcheung I have made the changes to limit the number of users being fetched as per previous comments.
Can you please review?
---
[GitHub] zeppelin issue #3045: ZEPPELIN-3570. Fix for doing user search for LDAPRealm
Posted by Tagar <gi...@git.apache.org>.
Github user Tagar commented on the issue:
https://github.com/apache/zeppelin/pull/3045
Can you guys please have a look at https://issues.apache.org/jira/browse/ZEPPELIN-3719 in case if this change caused that problem ?
---
[GitHub] zeppelin issue #3045: ZEPPELIN-3570. Fix for doing user search for LDAPRealm
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3045
@felixcheung Yes, that is how it is implemented for all the other realms as well, but then later it gets limited to 5 user result.
And you are right, should we modify all `getUserListObj.getUserList(realm, searchText)` (https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/rest/SecurityRestApi.java#L128-L134) to add another parameter `numberOfresults` so that they get limited there as well.
---
[GitHub] zeppelin issue #3045: ZEPPELIN-3570. Fix for doing user search for LDAPRealm
Posted by ssharma555 <gi...@git.apache.org>.
Github user ssharma555 commented on the issue:
https://github.com/apache/zeppelin/pull/3045
@prabhjyotsingh @zjffdu @gss2002 Can you please help review this ?
---
[GitHub] zeppelin pull request #3045: ZEPPELIN-3570. Fix for doing user search for LD...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3045
---