You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/11/03 07:54:59 UTC
[GitHub] [incubator-hugegraph-toolchain] simon824 opened a new pull request, #355: chore: improve hugegraph-client ut & stabilize hugegraph-client-ci
simon824 opened a new pull request, #355:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/355
refer to https://github.com/apache/incubator-hugegraph-toolchain/actions/runs/3383405590/jobs/5619268055
```
Error: Tests run: 100, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 207.147 s <<< FAILURE! - in com.baidu.hugegraph.functional.FuncTestSuite
Error: testAddVertexLabelWithUserData(com.baidu.hugegraph.functional.VertexLabelTest) Time elapsed: 0.539 s <<< FAILURE!
java.lang.AssertionError
at com.baidu.hugegraph.functional.VertexLabelTest.testAddVertexLabelWithUserData(VertexLabelTest.java:60)
Error: testAddEdgeLabelWithUserData(com.baidu.hugegraph.functional.EdgeLabelTest) Time elapsed: 2.563 s <<< FAILURE!
java.lang.AssertionError
at com.baidu.hugegraph.functional.EdgeLabelTest.testAddEdgeLabelWithUserData(EdgeLabelTest.java:97)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] javeme merged pull request #355: chore: improve hugegraph-client ut & stabilize hugegraph-client-ci
Posted by GitBox <gi...@apache.org>.
javeme merged PR #355:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] imbajin commented on a diff in pull request #355: chore: improve hugegraph-client ut & stabilize hugegraph-client-ci
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #355:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/355#discussion_r1013034214
##########
hugegraph-client/src/test/java/com/baidu/hugegraph/testutil/Utils.java:
##########
@@ -318,4 +318,9 @@ public static String formatDate(String date) {
public static String formatDate(Date date) {
return DATE_FORMAT.format(date);
}
+
+ public static void AssertTime(Date createTime) {
Review Comment:
seems we could make the method name clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] javeme commented on a diff in pull request #355: chore: improve hugegraph-client ut & stabilize hugegraph-client-ci
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #355:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/355#discussion_r1013055234
##########
hugegraph-client/src/test/java/com/baidu/hugegraph/testutil/Utils.java:
##########
@@ -318,4 +318,9 @@ public static String formatDate(String date) {
public static String formatDate(Date date) {
return DATE_FORMAT.format(date);
}
+
+ public static void AssertTime(Date createTime) {
Review Comment:
rename to assertBeforeNow()?
##########
hugegraph-client/src/test/java/com/baidu/hugegraph/api/EdgeLabelApiTest.java:
##########
@@ -19,6 +19,8 @@
package com.baidu.hugegraph.api;
+import static com.baidu.hugegraph.testutil.Utils.AssertTime;
Review Comment:
according to our style, prefer to import com.baidu.hugegraph.testutil.Utils then use Utils.xx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-toolchain] codecov[bot] commented on pull request #355: chore: improve hugegraph-client ut & stabilize hugegraph-client-ci
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #355:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/355#issuecomment-1301761247
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/355?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#355](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/355?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c6e6ad) into [master](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/commit/6374d5f0b53d9577b1dc826c81dc90636ecb0807?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6374d5f) will **increase** coverage by `77.33%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #355 +/- ##
=============================================
+ Coverage 0.00% 77.33% +77.33%
- Complexity 0 966 +966
=============================================
Files 86 156 +70
Lines 4031 4082 +51
Branches 478 242 -236
=============================================
+ Hits 0 3157 +3157
+ Misses 4031 746 -3285
- Partials 0 179 +179
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/355?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../baidu/hugegraph/loader/builder/VertexBuilder.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/355/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvbG9hZGVyL2J1aWxkZXIvVmVydGV4QnVpbGRlci5qYXZh) | | |
| [...a/com/baidu/hugegraph/loader/util/MappingUtil.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/355/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvbG9hZGVyL3V0aWwvTWFwcGluZ1V0aWwuamF2YQ==) | | |
| [...java/com/baidu/hugegraph/loader/util/JsonUtil.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/355/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvbG9hZGVyL3V0aWwvSnNvblV0aWwuamF2YQ==) | | |
| [...m/baidu/hugegraph/loader/reader/jdbc/JDBCUtil.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/355/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvbG9hZGVyL3JlYWRlci9qZGJjL0pEQkNVdGlsLmphdmE=) | | |
| [.../baidu/hugegraph/loader/struct/VertexStructV1.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/355/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvbG9hZGVyL3N0cnVjdC9WZXJ0ZXhTdHJ1Y3RWMS5qYXZh) | | |
| [...u/hugegraph/loader/spark/HugeGraphSparkLoader.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/355/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvbG9hZGVyL3NwYXJrL0h1Z2VHcmFwaFNwYXJrTG9hZGVyLmphdmE=) | | |
| [...a/com/baidu/hugegraph/loader/task/TaskManager.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/355/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvbG9hZGVyL3Rhc2svVGFza01hbmFnZXIuamF2YQ==) | | |
| [...aidu/hugegraph/loader/executor/GroovyExecutor.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/355/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvbG9hZGVyL2V4ZWN1dG9yL0dyb292eUV4ZWN1dG9yLmphdmE=) | | |
| [...om/baidu/hugegraph/loader/metrics/LoadSummary.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/355/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvbG9hZGVyL21ldHJpY3MvTG9hZFN1bW1hcnkuamF2YQ==) | | |
| [...a/com/baidu/hugegraph/loader/MappingConverter.java](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/355/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aHVnZWdyYXBoLWxvYWRlci9zcmMvbWFpbi9qYXZhL2NvbS9iYWlkdS9odWdlZ3JhcGgvbG9hZGVyL01hcHBpbmdDb252ZXJ0ZXIuamF2YQ==) | | |
| ... and [232 more](https://codecov.io/gh/apache/incubator-hugegraph-toolchain/pull/355/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org