You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/04/12 01:19:04 UTC

[jira] Created: (HADOOP-3240) TestJobShell should not create files in the current directory

TestJobShell should not create files in the current directory
-------------------------------------------------------------

                 Key: HADOOP-3240
                 URL: https://issues.apache.org/jira/browse/HADOOP-3240
             Project: Hadoop Core
          Issue Type: Bug
          Components: test
            Reporter: Tsz Wo (Nicholas), SZE
            Assignee: Mahadev konar
            Priority: Minor


After TestJobShell is done, a file "files_tmp" will be created in the current directory.  Testing files should be created under the test directory and be cleaned up once the test is done.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3240) TestJobShell should not create files in the current directory

Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602841#action_12602841 ] 

Hairong Kuang commented on HADOOP-3240:
---------------------------------------

+1 The patch looks good.

> TestJobShell should not create files in the current directory
> -------------------------------------------------------------
>
>                 Key: HADOOP-3240
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3240
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Mahadev konar
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: hadoop-3240_1.patch, hadoop-3240_2.patch, hadoop-3240_3.patch
>
>
> After TestJobShell is done, a file "files_tmp" will be created in the current directory.  Testing files should be created under the test directory and be cleaned up once the test is done.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3240) TestJobShell should not create files in the current directory

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated HADOOP-3240:
----------------------------------

    Status: Patch Available  (was: Open)

> TestJobShell should not create files in the current directory
> -------------------------------------------------------------
>
>                 Key: HADOOP-3240
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3240
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Mahadev konar
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: hadoop-3240_1.patch
>
>
> After TestJobShell is done, a file "files_tmp" will be created in the current directory.  Testing files should be created under the test directory and be cleaned up once the test is done.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3240) TestJobShell should not create files in the current directory

Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602833#action_12602833 ] 

Hairong Kuang commented on HADOOP-3240:
---------------------------------------

Better remove the temp directory in the test.

> TestJobShell should not create files in the current directory
> -------------------------------------------------------------
>
>                 Key: HADOOP-3240
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3240
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Mahadev konar
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: hadoop-3240_1.patch, hadoop-3240_2.patch
>
>
> After TestJobShell is done, a file "files_tmp" will be created in the current directory.  Testing files should be created under the test directory and be cleaned up once the test is done.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3240) TestJobShell should not create files in the current directory

Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Chansler updated HADOOP-3240:
------------------------------------

         Priority: Blocker  (was: Minor)
    Fix Version/s: 0.18.0

Promotion requested by QA.

> TestJobShell should not create files in the current directory
> -------------------------------------------------------------
>
>                 Key: HADOOP-3240
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3240
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Mahadev konar
>            Priority: Blocker
>             Fix For: 0.18.0
>
>
> After TestJobShell is done, a file "files_tmp" will be created in the current directory.  Testing files should be created under the test directory and be cleaned up once the test is done.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3240) TestJobShell should not create files in the current directory

Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hairong Kuang updated HADOOP-3240:
----------------------------------

    Comment: was deleted

> TestJobShell should not create files in the current directory
> -------------------------------------------------------------
>
>                 Key: HADOOP-3240
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3240
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Mahadev konar
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: hadoop-3240_1.patch, hadoop-3240_2.patch
>
>
> After TestJobShell is done, a file "files_tmp" will be created in the current directory.  Testing files should be created under the test directory and be cleaned up once the test is done.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3240) TestJobShell should not create files in the current directory

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated HADOOP-3240:
----------------------------------

    Attachment: hadoop-3240_2.patch

deleting the tmp dir in theend.

> TestJobShell should not create files in the current directory
> -------------------------------------------------------------
>
>                 Key: HADOOP-3240
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3240
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Mahadev konar
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: hadoop-3240_1.patch, hadoop-3240_2.patch
>
>
> After TestJobShell is done, a file "files_tmp" will be created in the current directory.  Testing files should be created under the test directory and be cleaned up once the test is done.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3240) TestJobShell should not create files in the current directory

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated HADOOP-3240:
----------------------------------

    Attachment: hadoop-3240_3.patch

forgot to delete the file in the old one.

> TestJobShell should not create files in the current directory
> -------------------------------------------------------------
>
>                 Key: HADOOP-3240
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3240
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Mahadev konar
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: hadoop-3240_1.patch, hadoop-3240_2.patch, hadoop-3240_3.patch
>
>
> After TestJobShell is done, a file "files_tmp" will be created in the current directory.  Testing files should be created under the test directory and be cleaned up once the test is done.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3240) TestJobShell should not create files in the current directory

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated HADOOP-3240:
----------------------------------

    Attachment: hadoop-3240_1.patch

this patch fixes the problem

> TestJobShell should not create files in the current directory
> -------------------------------------------------------------
>
>                 Key: HADOOP-3240
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3240
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Mahadev konar
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: hadoop-3240_1.patch
>
>
> After TestJobShell is done, a file "files_tmp" will be created in the current directory.  Testing files should be created under the test directory and be cleaned up once the test is done.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-3240) TestJobShell should not create files in the current directory

Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Devaraj Das updated HADOOP-3240:
--------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this. Thanks, Mahadev!

> TestJobShell should not create files in the current directory
> -------------------------------------------------------------
>
>                 Key: HADOOP-3240
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3240
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Mahadev konar
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: hadoop-3240_1.patch, hadoop-3240_2.patch, hadoop-3240_3.patch
>
>
> After TestJobShell is done, a file "files_tmp" will be created in the current directory.  Testing files should be created under the test directory and be cleaned up once the test is done.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-3240) TestJobShell should not create files in the current directory

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-3240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12602927#action_12602927 ] 

Hadoop QA commented on HADOOP-3240:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12383514/hadoop-3240_3.patch
  against trunk revision 663812.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 5 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2600/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2600/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2600/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2600/console

This message is automatically generated.

> TestJobShell should not create files in the current directory
> -------------------------------------------------------------
>
>                 Key: HADOOP-3240
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3240
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: test
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Mahadev konar
>            Priority: Blocker
>             Fix For: 0.18.0
>
>         Attachments: hadoop-3240_1.patch, hadoop-3240_2.patch, hadoop-3240_3.patch
>
>
> After TestJobShell is done, a file "files_tmp" will be created in the current directory.  Testing files should be created under the test directory and be cleaned up once the test is done.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.