You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by khalidhuseynov <gi...@git.apache.org> on 2016/11/03 11:51:29 UTC

[GitHub] zeppelin pull request #1590: [ZEPPELIN-1612] Fix NPE when initializing Noteb...

GitHub user khalidhuseynov opened a pull request:

    https://github.com/apache/zeppelin/pull/1590

    [ZEPPELIN-1612] Fix NPE when initializing Notebook

    ### What is this PR for?
    Sometimes Zeppelin wasn't able to start because of empty subject when initializing Notebook class, more details in issue.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [x] - add anonymous subject
    * [x] - add test
    
    ### What is the Jira issue?
    [ZEPPELIN-1612](https://issues.apache.org/jira/browse/ZEPPELIN-1612)
    
    ### How should this be tested?
    * added test passing and no relevant CI failures
    * also can be starting Zeppelin in anonymous mode when you have notes with angular objects
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/incubator-zeppelin fix/loadAllNotes-npe

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1590.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1590
    
----
commit 3dc0a8ba58037d2509a6a57397dc502e859814e1
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2016-11-03T10:38:11Z

    substitute null with anonymous subject

commit 8da069b8bc600cd68b8c098fa0eb7a1e6025dc6e
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2016-11-03T11:44:44Z

    add test
    
    for testing the opposite case need note with angular object

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1590: [ZEPPELIN-1612] Fix NPE when initializing Notebook

Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/1590
  
    @bzz that function `loadAllNotes` is called only from constructor and when loading from constructor you're either in anonymous mode, or in shiro and loading all notes by anonymous (public). For the cases when specific user logs in another function for reloading note in [here](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java#L479) is called with specific user credentials.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1590: [ZEPPELIN-1612] Fix NPE when initializing Noteb...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1590


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1590: [ZEPPELIN-1612] Fix NPE when initializing Notebook

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1590
  
    Got it! Thank you for kind explanation.
    
    CI failure looks not relevant for the change set.
    
    Looks great to me, merging to master if there is no further discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1590: [ZEPPELIN-1612] Fix NPE when initializing Notebook

Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1590
  
    Just wonder if that means that notes are always load as `anonymous` irregarding Zeppelin mode, because we do not have such permissions yet?
    
    Curious, as I would expect that we would load all notes for a specific user, in case auth is enabled in Zeppelin..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---