You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2008/07/30 12:25:32 UTC
[jira] Commented: (HADOOP-3861) Make MapFile.Reader and Writer
implement java.io.Closeable
[ https://issues.apache.org/jira/browse/HADOOP-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618282#action_12618282 ]
Hadoop QA commented on HADOOP-3861:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12387171/hadoop-3861.patch
against trunk revision 680823.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2982/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2982/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2982/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2982/console
This message is automatically generated.
> Make MapFile.Reader and Writer implement java.io.Closeable
> ----------------------------------------------------------
>
> Key: HADOOP-3861
> URL: https://issues.apache.org/jira/browse/HADOOP-3861
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Reporter: Tom White
> Assignee: Tom White
> Attachments: hadoop-3861.patch
>
>
> Both MapFile.Reader and Writer have a close() method with the right signature. They just need to declare that they implement Closeable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.