You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/10/21 13:12:00 UTC

[jira] [Commented] (PROTON-2123) Proton can produce invalid utf-8 in PN_TRACE_FRM=1 logs

    [ https://issues.apache.org/jira/browse/PROTON-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16956058#comment-16956058 ] 

ASF GitHub Bot commented on PROTON-2123:
----------------------------------------

jdanekrh commented on pull request #197: PROTON-2123 Escape every char >127 printed into logs
URL: https://github.com/apache/qpid-proton/pull/197
 
 
   As mentioned on the DISPATCH issue, I don't know what exactly is causing me problems, and I don't have standalone reproducer, but this does fix the issue for me and the patch does not look completely unreasonable on its own.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Proton can produce invalid utf-8 in PN_TRACE_FRM=1 logs
> -------------------------------------------------------
>
>                 Key: PROTON-2123
>                 URL: https://issues.apache.org/jira/browse/PROTON-2123
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>    Affects Versions: proton-c-0.29.0
>         Environment: macOS 10.14, when running qdrouterd tests
>            Reporter: Jiri Daněk
>            Priority: Major
>
> As discovered on DISPATCH-1384, qdrouterd can sometimes produce invalid utf-8 in TRACE output.
> https://issues.apache.org/jira/browse/DISPATCH-1384?focusedCommentId=16955281&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16955281
> It may look like this
> {noformat}
> 2019-10-21 01:46:38.790093 -0700 SERVER (trace) [3]:0 <- @transfer(20) [handle=1, delivery-id=0, delivery-tag=b"\x01\x00\x00\x00\x00\x00\x00\x00", message-format=0, settled=true] (228) "\x00Sp<D0>\x00\x00\x00\x05\x00\x00\x00\x01B\x00Sr<D1>\x00\x00\x00U\x00\x00\x00\x08<A3>\x0ex-opt-qd.trace<D0>\x00\x00\x00\x09\x00\x00\x00\x01<A1>\x030/B<A3>\x10x-opt-qd.ingress<A1>\x030/B<A3>\x09x-opt-qd.<A1>\x01X<A3>\x09x-opt-qd.<A1>\x01X\x00Ss<D0>\x00\x00\x00\x1f\x00\x00\x00\x06@@<A1>\x14amqp:/_local/qdhello@@@\x00St<D1>\x00\x00\x00\x13\x00\x00\x00\x02<A1>\x06opcode<A1>\x05HELLO\x00Sw<D1>\x00\x00\x000\x00\x00\x00\x0a<A1>\x02id<A1>\x01B<A1>\x02pvT\x01<A1>\x04area<A1>\x010<A1>\x08instanceq]<AD>pm<A1>\x04seenE" (/Users/cloud-user/repos/qpid/qpid-dispatch/src/server.c:107)
> {noformat}
> The {{<D0>}} and so on is how {{less}} deals with such characters.
> I'd expect to see {{\xd0}} etc. instead.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org