You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2014/08/25 17:24:12 UTC
svn commit: r1620343 -
/lucene/dev/branches/lucene5904/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java
Author: mikemccand
Date: Mon Aug 25 15:24:12 2014
New Revision: 1620343
URL: http://svn.apache.org/r1620343
Log:
LUCENE-5904: fix false test failure
Modified:
lucene/dev/branches/lucene5904/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java
Modified: lucene/dev/branches/lucene5904/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene5904/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java?rev=1620343&r1=1620342&r2=1620343&view=diff
==============================================================================
--- lucene/dev/branches/lucene5904/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java (original)
+++ lucene/dev/branches/lucene5904/lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java Mon Aug 25 15:24:12 2014
@@ -311,21 +311,31 @@ public class TestIndexWriter extends Luc
.setRAMBufferSizeMB(0.000001)
.setMergePolicy(newLogMergePolicy(10))
);
- int lastNumFile = dir.listAll().length;
+ int lastNumSegments = getSegmentCount(dir);
for(int j=0;j<9;j++) {
Document doc = new Document();
doc.add(newField("field", "aaa" + j, storedTextType));
writer.addDocument(doc);
- int numFile = dir.listAll().length;
// Verify that with a tiny RAM buffer we see new
// segment after every doc
- assertTrue("numFile=" + numFile + " lastNumFile=" + lastNumFile, numFile > lastNumFile);
- lastNumFile = numFile;
+ int numSegments = getSegmentCount(dir);
+ assertTrue(numSegments > lastNumSegments);
+ lastNumSegments = numSegments;
}
writer.close();
dir.close();
}
+ /** Returns how many unique segment names are in the directory. */
+ private static int getSegmentCount(Directory dir) throws IOException {
+ Set<String> segments = new HashSet<>();
+ for(String file : dir.listAll()) {
+ segments.add(IndexFileNames.parseSegmentName(file));
+ }
+
+ return segments.size();
+ }
+
// Make sure it's OK to change RAM buffer size and
// maxBufferedDocs in a write session
public void testChangingRAMBuffer() throws IOException {