You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/03 21:54:33 UTC
[GitHub] [spark] holdenk opened a new pull request, #36443: [POC][WIP][SPARK-39088][CORE] Add a "live" driver link to the UI for history server when serving in-progress applications.
holdenk opened a new pull request, #36443:
URL: https://github.com/apache/spark/pull/36443
### What changes were proposed in this pull request?
Add a link to the driver's live UI if present when serving the history server.
### Why are the changes needed?
While YARN has a proxy that transparently redirects between live and history server this is not the case for other cluster managers.
### Does this PR introduce _any_ user-facing change?
New UI element.
### How was this patch tested?
WIP + manual
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #36443: [POC][WIP][SPARK-39088][CORE] Add a "live" driver link to the UI for history server when serving in-progress applications.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #36443:
URL: https://github.com/apache/spark/pull/36443#issuecomment-1321290211
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #36443: [POC][WIP][SPARK-39088][CORE] Add a "live" driver link to the UI for history server when serving in-progress applications.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #36443: [POC][WIP][SPARK-39088][CORE] Add a "live" driver link to the UI for history server when serving in-progress applications.
URL: https://github.com/apache/spark/pull/36443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] martin-g commented on a diff in pull request #36443: [POC][WIP][SPARK-39088][CORE] Add a "live" driver link to the UI for history server when serving in-progress applications.
Posted by GitBox <gi...@apache.org>.
martin-g commented on code in PR #36443:
URL: https://github.com/apache/spark/pull/36443#discussion_r864523944
##########
core/src/main/scala/org/apache/spark/status/AppStatusStore.scala:
##########
@@ -763,6 +767,8 @@ private[spark] class AppStatusStore(
AppStatusUtils.gettingResultTime(taskDataOld))
}.toSeq
}
+
+ private[spark] def isHistory(): Boolean = true
Review Comment:
```suggestion
private[spark] def isHistory(): Boolean = false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org