You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@allura.apache.org by br...@apache.org on 2016/08/09 14:43:13 UTC

[1/3] allura git commit: [#8104] fixed test failiure in test_move_ticket_email_notifications

Repository: allura
Updated Branches:
  refs/heads/master eb0d955ae -> 1750de2b1


[#8104] fixed test failiure in test_move_ticket_email_notifications


Project: http://git-wip-us.apache.org/repos/asf/allura/repo
Commit: http://git-wip-us.apache.org/repos/asf/allura/commit/1750de2b
Tree: http://git-wip-us.apache.org/repos/asf/allura/tree/1750de2b
Diff: http://git-wip-us.apache.org/repos/asf/allura/diff/1750de2b

Branch: refs/heads/master
Commit: 1750de2b1604b0b64eb27453a423f5338ad30474
Parents: cab17d9
Author: Rohan Verma <ro...@gmail.com>
Authored: Tue Aug 9 00:06:30 2016 +0530
Committer: Dave Brondsema <da...@brondsema.net>
Committed: Tue Aug 9 10:41:13 2016 -0400

----------------------------------------------------------------------
 ForgeTracker/forgetracker/tracker_main.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/allura/blob/1750de2b/ForgeTracker/forgetracker/tracker_main.py
----------------------------------------------------------------------
diff --git a/ForgeTracker/forgetracker/tracker_main.py b/ForgeTracker/forgetracker/tracker_main.py
index 5200b2c..9fcab09 100644
--- a/ForgeTracker/forgetracker/tracker_main.py
+++ b/ForgeTracker/forgetracker/tracker_main.py
@@ -1542,7 +1542,7 @@ class TicketController(BaseController, FeedController):
         post_text, notification_text = render_changes(changes, comment)
 
         thread = self.ticket.discussion_thread
-        if changes.get_changed() or post_text:
+        if changes.get_changed() or post_text or notification_text:
             thread.add_post(text=post_text, is_meta=True,
                         notification_text=notification_text)
         self.ticket.commit()


[2/3] allura git commit: [#8104] bug squashed which was found in test_move_ticket_email_notifications

Posted by br...@apache.org.
[#8104] bug squashed which was found in test_move_ticket_email_notifications


Project: http://git-wip-us.apache.org/repos/asf/allura/repo
Commit: http://git-wip-us.apache.org/repos/asf/allura/commit/cab17d9f
Tree: http://git-wip-us.apache.org/repos/asf/allura/tree/cab17d9f
Diff: http://git-wip-us.apache.org/repos/asf/allura/diff/cab17d9f

Branch: refs/heads/master
Commit: cab17d9f9977f1f5d2c76871be8f28ec00e63785
Parents: 2626a46
Author: Rohan Verma <ro...@gmail.com>
Authored: Tue Jul 26 14:44:14 2016 +0530
Committer: Dave Brondsema <da...@brondsema.net>
Committed: Tue Aug 9 10:41:13 2016 -0400

----------------------------------------------------------------------
 ForgeTracker/forgetracker/tracker_main.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/allura/blob/cab17d9f/ForgeTracker/forgetracker/tracker_main.py
----------------------------------------------------------------------
diff --git a/ForgeTracker/forgetracker/tracker_main.py b/ForgeTracker/forgetracker/tracker_main.py
index 17d7f8d..5200b2c 100644
--- a/ForgeTracker/forgetracker/tracker_main.py
+++ b/ForgeTracker/forgetracker/tracker_main.py
@@ -1542,7 +1542,7 @@ class TicketController(BaseController, FeedController):
         post_text, notification_text = render_changes(changes, comment)
 
         thread = self.ticket.discussion_thread
-        if changes.get_changed():
+        if changes.get_changed() or post_text:
             thread.add_post(text=post_text, is_meta=True,
                         notification_text=notification_text)
         self.ticket.commit()


[3/3] allura git commit: [#8104] Skip creating metapost if list of changes is empty

Posted by br...@apache.org.
[#8104] Skip creating metapost if list of changes is empty


Project: http://git-wip-us.apache.org/repos/asf/allura/repo
Commit: http://git-wip-us.apache.org/repos/asf/allura/commit/2626a466
Tree: http://git-wip-us.apache.org/repos/asf/allura/tree/2626a466
Diff: http://git-wip-us.apache.org/repos/asf/allura/diff/2626a466

Branch: refs/heads/master
Commit: 2626a466723be6aa2a0ac9e424da20ad6042be2e
Parents: eb0d955
Author: Rohan Verma <ro...@gmail.com>
Authored: Tue Jul 19 04:10:46 2016 +0530
Committer: Dave Brondsema <da...@brondsema.net>
Committed: Tue Aug 9 10:41:13 2016 -0400

----------------------------------------------------------------------
 ForgeTracker/forgetracker/tracker_main.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/allura/blob/2626a466/ForgeTracker/forgetracker/tracker_main.py
----------------------------------------------------------------------
diff --git a/ForgeTracker/forgetracker/tracker_main.py b/ForgeTracker/forgetracker/tracker_main.py
index 91f354d..17d7f8d 100644
--- a/ForgeTracker/forgetracker/tracker_main.py
+++ b/ForgeTracker/forgetracker/tracker_main.py
@@ -1540,8 +1540,10 @@ class TicketController(BaseController, FeedController):
                 changes[cf.label] = cf_val(cf)
 
         post_text, notification_text = render_changes(changes, comment)
+
         thread = self.ticket.discussion_thread
-        thread.add_post(text=post_text, is_meta=True,
+        if changes.get_changed():
+            thread.add_post(text=post_text, is_meta=True,
                         notification_text=notification_text)
         self.ticket.commit()
         if comment: