You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Hari Shreedharan <hs...@cloudera.com> on 2012/09/12 23:40:15 UTC
Re: Review Request: FLUME-1571. Make sure capacity and transaction capacity
of channels are positive.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7062/
-----------------------------------------------------------
(Updated Sept. 12, 2012, 9:40 p.m.)
Review request for Flume.
Changes
-------
Changing JIRA number to the correct one.
Summary (updated)
-----------------
FLUME-1571. Make sure capacity and transaction capacity of channels are positive.
Description
-------
Add checks to make sure they are positive, if not, reset to default.
This addresses bug FLUME-1571.
https://issues.apache.org/jira/browse/FLUME-1571
Diffs
-----
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java 66f7536
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java 8baf8fe
flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java c72e97c
flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java e070864
Diff: https://reviews.apache.org/r/7062/diff/
Testing
-------
Added unit tests.
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1571. Make sure capacity and transaction capacity
of channels are positive.
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7062/#review14112
-----------------------------------------------------------
flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java
<https://reviews.apache.org/r/7062/#comment30180>
Nit: The error messages are missing some spaces.
flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java
<https://reviews.apache.org/r/7062/#comment30178>
Wish: Can we add a error message to this line as well?
- Brock Noland
On Sept. 12, 2012, 9:40 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7062/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2012, 9:40 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Add checks to make sure they are positive, if not, reset to default.
>
>
> This addresses bug FLUME-1571.
> https://issues.apache.org/jira/browse/FLUME-1571
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java 66f7536
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java 8baf8fe
> flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java c72e97c
> flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java e070864
>
> Diff: https://reviews.apache.org/r/7062/diff/
>
>
> Testing
> -------
>
> Added unit tests.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1571. Make sure capacity and transaction capacity
of channels are positive.
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7062/#review14304
-----------------------------------------------------------
Ship it!
Ship It!
- Brock Noland
On Dec. 11, 2012, 7:29 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7062/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2012, 7:29 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Add checks to make sure they are positive, if not, reset to default.
>
>
> This addresses bug FLUME-1571.
> https://issues.apache.org/jira/browse/FLUME-1571
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java 950ea8c
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestCheckpointRebuilder.java ffc4623
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java 87a0a3f
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelFormatRegression.java 184f956
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java f548f31
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestUtils.java 9978f86
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestFileChannelEncryption.java d2f5208
> flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java 87a1305
> flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java e1a61c2
>
> Diff: https://reviews.apache.org/r/7062/diff/
>
>
> Testing
> -------
>
> Added unit tests.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1571. Make sure capacity and transaction capacity
of channels are positive.
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7062/
-----------------------------------------------------------
(Updated Dec. 11, 2012, 7:29 p.m.)
Review request for Flume.
Description
-------
Add checks to make sure they are positive, if not, reset to default.
This addresses bug FLUME-1571.
https://issues.apache.org/jira/browse/FLUME-1571
Diffs (updated)
-----
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java 950ea8c
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestCheckpointRebuilder.java ffc4623
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java 87a0a3f
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelFormatRegression.java 184f956
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java f548f31
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestUtils.java 9978f86
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestFileChannelEncryption.java d2f5208
flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java 87a1305
flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java e1a61c2
Diff: https://reviews.apache.org/r/7062/diff/
Testing
-------
Added unit tests.
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1571. Make sure capacity and transaction capacity
of channels are positive.
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7062/
-----------------------------------------------------------
(Updated Dec. 11, 2012, midnight)
Review request for Flume.
Description
-------
Add checks to make sure they are positive, if not, reset to default.
This addresses bug FLUME-1571.
https://issues.apache.org/jira/browse/FLUME-1571
Diffs (updated)
-----
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java 64a1350
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java 87a0a3f
flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java 87a1305
flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java e1a61c2
Diff: https://reviews.apache.org/r/7062/diff/
Testing
-------
Added unit tests.
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1571. Make sure capacity and transaction capacity
of channels are positive.
Posted by Brock Noland <br...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7062/#review14276
-----------------------------------------------------------
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
<https://reviews.apache.org/r/7062/#comment30409>
I think we should specify this is transaction capacity.
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
<https://reviews.apache.org/r/7062/#comment30410>
This isn't the checkpoint write time out as the message indicates, it's the checkpoint interval.
- Brock Noland
On Dec. 10, 2012, 7:07 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7062/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2012, 7:07 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Add checks to make sure they are positive, if not, reset to default.
>
>
> This addresses bug FLUME-1571.
> https://issues.apache.org/jira/browse/FLUME-1571
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java 64a1350
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java 87a0a3f
> flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java 87a1305
> flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java e1a61c2
>
> Diff: https://reviews.apache.org/r/7062/diff/
>
>
> Testing
> -------
>
> Added unit tests.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1571. Make sure capacity and transaction capacity
of channels are positive.
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7062/
-----------------------------------------------------------
(Updated Dec. 10, 2012, 7:07 p.m.)
Review request for Flume.
Description
-------
Add checks to make sure they are positive, if not, reset to default.
This addresses bug FLUME-1571.
https://issues.apache.org/jira/browse/FLUME-1571
Diffs (updated)
-----
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java 64a1350
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java 87a0a3f
flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java 87a1305
flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java e1a61c2
Diff: https://reviews.apache.org/r/7062/diff/
Testing
-------
Added unit tests.
Thanks,
Hari Shreedharan
Re: Review Request: FLUME-1571. Make sure capacity and transaction capacity
of channels are positive.
Posted by Hari Shreedharan <hs...@cloudera.com>.
> On Sept. 25, 2012, 10:45 p.m., Hari Shreedharan wrote:
> > Bump.
Committers: Requesting review.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7062/#review11911
-----------------------------------------------------------
On Sept. 12, 2012, 9:40 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7062/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2012, 9:40 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Add checks to make sure they are positive, if not, reset to default.
>
>
> This addresses bug FLUME-1571.
> https://issues.apache.org/jira/browse/FLUME-1571
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java 66f7536
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java 8baf8fe
> flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java c72e97c
> flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java e070864
>
> Diff: https://reviews.apache.org/r/7062/diff/
>
>
> Testing
> -------
>
> Added unit tests.
>
>
> Thanks,
>
> Hari Shreedharan
>
>
Re: Review Request: FLUME-1571. Make sure capacity and transaction capacity
of channels are positive.
Posted by Hari Shreedharan <hs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7062/#review11911
-----------------------------------------------------------
Bump.
- Hari Shreedharan
On Sept. 12, 2012, 9:40 p.m., Hari Shreedharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7062/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2012, 9:40 p.m.)
>
>
> Review request for Flume.
>
>
> Description
> -------
>
> Add checks to make sure they are positive, if not, reset to default.
>
>
> This addresses bug FLUME-1571.
> https://issues.apache.org/jira/browse/FLUME-1571
>
>
> Diffs
> -----
>
> flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java 66f7536
> flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java 8baf8fe
> flume-ng-core/src/main/java/org/apache/flume/channel/MemoryChannel.java c72e97c
> flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java e070864
>
> Diff: https://reviews.apache.org/r/7062/diff/
>
>
> Testing
> -------
>
> Added unit tests.
>
>
> Thanks,
>
> Hari Shreedharan
>
>