You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xuxin930 (via GitHub)" <gi...@apache.org> on 2024/03/29 07:32:40 UTC
[PR] Make.defs:make all AROBJS and OBJS batch cleaned in Application [nuttx-apps]
xuxin930 opened a new pull request, #2343:
URL: https://github.com/apache/nuttx-apps/pull/2343
## Summary
hi @xiaoxiang781216 @anchao
I saw the issue discussed in this PR https://github.com/apache/nuttx/pull/11997 about ltp failure
we previously used batch splitting to solve the problem of `argument too long` during compilation.
but there is a problem here in `nuttx/tools/Config.mk`
application `OBJS` clean call `CLEAN` macro defined in nuttx/tools/Config.mk
variables are expand directly within the marco.
https://github.com/apache/nuttx/blob/806d783fd6dab9cb4de79da2516e9ece71b4efdc/tools/Config.mk#L597-L601
this is no problem in the nuttx call, because the obj generated by nuttx compilation definitely does not have a suffix.
however, there is uncertainty in the obj expansion of the Applications call.
---
This patch follows the previous design of batch splitting and performs batch **deletion**.
**and at the same time, reset the OBJS variables** , $(OBJS) remove in Application CLEAN before CLEANAROBJS:
```
clean::
$(call DELFILE, .built)
$(call CLEANAROBJS)
$(call CLEAN)
```
I plan to keep OBJS CLEAN in non-apps build here, delete and reset OBJS in batches in apps build.
## Impact
make distclean
## Testing
CI build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make.defs:make all AROBJS and OBJS batch cleaned in Application [nuttx-apps]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #2343:
URL: https://github.com/apache/nuttx-apps/pull/2343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org