You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/14 10:54:59 UTC
[GitHub] [cloudstack] rhtyd opened a new pull request #4326: ui: call logout before login to clear old sessionkey cookies
rhtyd opened a new pull request #4326:
URL: https://github.com/apache/cloudstack/pull/4326
This handle edge cases of upgrades and when legacy UI is used along with
Primate or any UI sharing cookies. The specific case it fixes involves
removal of duplicate sessionkey cookies.
Fixes #4324
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## How Has This Been Tested?
1. Logout and create a fake sessionkey cookie using `$.cookie('sessionkey', '123')`
2. Try to login, login will fail and in the request two sessionkey cookies will be seen passed:
With the fix, when logout is called the API will clear sessionkey cookie (which is httponly so only the backend/server can remove it); and login works. This will cover issues after upgrades and when using legacy UI with Primate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani edited a comment on pull request #4326: ui: call logout before login to clear old sessionkey cookies
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #4326:
URL: https://github.com/apache/cloudstack/pull/4326#issuecomment-692577561
Unable to log in from an old to this build of the management server without clearing cookies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4326: ui: call logout before login to clear old sessionkey cookies
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4326:
URL: https://github.com/apache/cloudstack/pull/4326#issuecomment-691978221
Please review - @Pearl1594 @davidjumani @utchoang @andrijapanicsb @svenvogel and rest. Thnx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani removed a comment on pull request #4326: ui: call logout before login to clear old sessionkey cookies
Posted by GitBox <gi...@apache.org>.
davidjumani removed a comment on pull request #4326:
URL: https://github.com/apache/cloudstack/pull/4326#issuecomment-692577561
Unable to log in from an old to this build of the management server without clearing cookies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4326: ui: call logout before login to clear old sessionkey cookies
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4326:
URL: https://github.com/apache/cloudstack/pull/4326#issuecomment-692558560
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2008
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4326: ui: call logout before login to clear old sessionkey cookies
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4326:
URL: https://github.com/apache/cloudstack/pull/4326#issuecomment-692533434
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4326: ui: call logout before login to clear old sessionkey cookies
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4326:
URL: https://github.com/apache/cloudstack/pull/4326#issuecomment-692537986
Sorry @utchoang the blueorangutan package for old UI wont' setup a live demo to test that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4326: ui: call logout before login to clear old sessionkey cookies
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4326:
URL: https://github.com/apache/cloudstack/pull/4326#issuecomment-692558560
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2008
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4326: ui: call logout before login to clear old sessionkey cookies
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4326:
URL: https://github.com/apache/cloudstack/pull/4326#issuecomment-692538434
@rhtyd OK. I'll run and test on my local. Thnks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4326: ui: call logout before login to clear old sessionkey cookies
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4326:
URL: https://github.com/apache/cloudstack/pull/4326
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4326: ui: call logout before login to clear old sessionkey cookies
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4326:
URL: https://github.com/apache/cloudstack/pull/4326#issuecomment-692533706
@utchoang a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4326: ui: call logout before login to clear old sessionkey cookies
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4326:
URL: https://github.com/apache/cloudstack/pull/4326#issuecomment-692577561
Unable to log in from an upgrade / restart of the management server without clearing cookies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org