You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "lyy-pineapple (via GitHub)" <gi...@apache.org> on 2023/10/07 03:49:24 UTC
[PR] [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table [spark]
lyy-pineapple opened a new pull request, #43258:
URL: https://github.com/apache/spark/pull/43258
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #43258:
URL: https://github.com/apache/spark/pull/43258#issuecomment-1751927950
> Thank you for your review. All tests have passed. Do you have any further feedback or suggestions? @beliefer
I'm OK. Please wait for the other owner's review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #43258:
URL: https://github.com/apache/spark/pull/43258#discussion_r1349854974
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala:
##########
@@ -512,4 +513,19 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
assert(t.schema === replaced)
}
}
+
+ test("SPARK-45449: Cache Invalidation Issue with JDBC Table") {
+ withTable("h2.test.cache_t") {
+ withConnection { conn =>
+ conn.prepareStatement(
+ """CREATE TABLE "test"."cache_t" (id decimal(25) PRIMARY KEY NOT NULL,
+ |name TEXT(32) NOT NULL)""".stripMargin).executeUpdate()
+ }
+ sql("INSERT OVERWRITE h2.test.cache_t SELECT 1 AS id, 'a' AS name")
+ sql("CACHE TABLE t1 SELECT id, name FROM h2.test.cache_t")
+ val plan = sql("select * from t1").queryExecution.sparkPlan
+ assert(plan.isInstanceOf[InMemoryTableScanExec])
+ sql("UNCACHE TABLE IF EXISTS t1")
Review Comment:
nit: we don't need this UNCACHE TABLE as `withTable` will drop the table at the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #43258:
URL: https://github.com/apache/spark/pull/43258#issuecomment-1752334892
This is a good catch! I just have one question though: `JDBCOptions` is also used in JDBC v1, why does v1 not have this cache issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #43258:
URL: https://github.com/apache/spark/pull/43258#discussion_r1349458691
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala:
##########
@@ -46,6 +46,14 @@ class JDBCOptions(
JDBCOptions.JDBC_TABLE_NAME -> table)))
}
+ override def hashCode: Int = this.parameters.hashCode()
+
+ override def equals(other: Any): Boolean = other match {
+ case otherOption: JDBCOptions =>
+ otherOption.parameters.equals(this.parameters)
+ case _ => false
+ }
Review Comment:
Shall we put `hashCode` and `equals` at the tail of `JDBCOptions` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table [spark]
Posted by "lyy-pineapple (via GitHub)" <gi...@apache.org>.
lyy-pineapple commented on code in PR #43258:
URL: https://github.com/apache/spark/pull/43258#discussion_r1349485917
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala:
##########
@@ -515,17 +515,17 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
}
test("SPARK-45449: Cache Invalidation Issue with JDBC Table") {
- withConnection { conn =>
- conn.prepareStatement(
- """CREATE TABLE "test"."cache_t" (id decimal(25) PRIMARY KEY NOT NULL,
- |name TEXT(32) NOT NULL)""".stripMargin).executeUpdate()
+ withTable("h2.test.cache_t") {
+ withConnection { conn =>
+ conn.prepareStatement(
+ """CREATE TABLE "test"."cache_t" (id decimal(25) PRIMARY KEY NOT NULL,
+ |name TEXT(32) NOT NULL)""".stripMargin).executeUpdate()
+ }
+ sql("INSERT OVERWRITE h2.test.cache_t SELECT 1 AS id, 'a' AS name")
+ sql("CACHE TABLE t1 SELECT id, name FROM h2.test.cache_t")
+ val plan = sql("select * from t1").queryExecution.sparkPlan
+ assert(plan.isInstanceOf[InMemoryTableScanExec])
+ sql("UNCACHE TABLE IF EXISTS t1")
Review Comment:
yeah, I put it inside the withTable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table [spark]
Posted by "lyy-pineapple (via GitHub)" <gi...@apache.org>.
lyy-pineapple commented on PR #43258:
URL: https://github.com/apache/spark/pull/43258#issuecomment-1752469043
> This is a good catch! I just have one question though: `JDBCOptions` is also used in JDBC v1, why does v1 not have this cache issue?
Debugging revealed that when using v1, the construction of LogicalRelation through makeCopy reused JDBCRelation. Perhaps, someday, this could pose a potential issue for v1 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #43258: [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table
URL: https://github.com/apache/spark/pull/43258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table [spark]
Posted by "lyy-pineapple (via GitHub)" <gi...@apache.org>.
lyy-pineapple commented on PR #43258:
URL: https://github.com/apache/spark/pull/43258#issuecomment-1751911149
Thank you for your review. All tests have passed. Do you have any further feedback or suggestions? @beliefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #43258:
URL: https://github.com/apache/spark/pull/43258#discussion_r1349480232
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala:
##########
@@ -515,17 +515,17 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
}
test("SPARK-45449: Cache Invalidation Issue with JDBC Table") {
- withConnection { conn =>
- conn.prepareStatement(
- """CREATE TABLE "test"."cache_t" (id decimal(25) PRIMARY KEY NOT NULL,
- |name TEXT(32) NOT NULL)""".stripMargin).executeUpdate()
+ withTable("h2.test.cache_t") {
+ withConnection { conn =>
+ conn.prepareStatement(
+ """CREATE TABLE "test"."cache_t" (id decimal(25) PRIMARY KEY NOT NULL,
+ |name TEXT(32) NOT NULL)""".stripMargin).executeUpdate()
+ }
+ sql("INSERT OVERWRITE h2.test.cache_t SELECT 1 AS id, 'a' AS name")
+ sql("CACHE TABLE t1 SELECT id, name FROM h2.test.cache_t")
+ val plan = sql("select * from t1").queryExecution.sparkPlan
+ assert(plan.isInstanceOf[InMemoryTableScanExec])
+ sql("UNCACHE TABLE IF EXISTS t1")
Review Comment:
`withTable` is OK too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #43258:
URL: https://github.com/apache/spark/pull/43258#issuecomment-1754497294
thanks, merging to master/3.5!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table [spark]
Posted by "lyy-pineapple (via GitHub)" <gi...@apache.org>.
lyy-pineapple commented on code in PR #43258:
URL: https://github.com/apache/spark/pull/43258#discussion_r1349478329
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala:
##########
@@ -46,6 +46,14 @@ class JDBCOptions(
JDBCOptions.JDBC_TABLE_NAME -> table)))
}
+ override def hashCode: Int = this.parameters.hashCode()
+
+ override def equals(other: Any): Boolean = other match {
+ case otherOption: JDBCOptions =>
+ otherOption.parameters.equals(this.parameters)
+ case _ => false
+ }
Review Comment:
Done
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala:
##########
@@ -512,4 +513,19 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
assert(t.schema === replaced)
}
}
+
+ test("SPARK-45449: Cache Invalidation Issue with JDBC Table") {
+ withConnection { conn =>
+ conn.prepareStatement(
+ """CREATE TABLE "test"."cache_t" (id decimal(25) PRIMARY KEY NOT NULL,
+ |name TEXT(32) NOT NULL)""".stripMargin).executeUpdate()
+ }
+ val ss = spark.cloneSession()
Review Comment:
It has been removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table [spark]
Posted by "lyy-pineapple (via GitHub)" <gi...@apache.org>.
lyy-pineapple commented on code in PR #43258:
URL: https://github.com/apache/spark/pull/43258#discussion_r1349937372
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala:
##########
@@ -512,4 +513,19 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
assert(t.schema === replaced)
}
}
+
+ test("SPARK-45449: Cache Invalidation Issue with JDBC Table") {
+ withTable("h2.test.cache_t") {
+ withConnection { conn =>
+ conn.prepareStatement(
+ """CREATE TABLE "test"."cache_t" (id decimal(25) PRIMARY KEY NOT NULL,
+ |name TEXT(32) NOT NULL)""".stripMargin).executeUpdate()
+ }
+ sql("INSERT OVERWRITE h2.test.cache_t SELECT 1 AS id, 'a' AS name")
+ sql("CACHE TABLE t1 SELECT id, name FROM h2.test.cache_t")
+ val plan = sql("select * from t1").queryExecution.sparkPlan
+ assert(plan.isInstanceOf[InMemoryTableScanExec])
+ sql("UNCACHE TABLE IF EXISTS t1")
Review Comment:
thanks， I has removed it
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala:
##########
@@ -512,4 +513,19 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
assert(t.schema === replaced)
}
}
+
+ test("SPARK-45449: Cache Invalidation Issue with JDBC Table") {
+ withTable("h2.test.cache_t") {
+ withConnection { conn =>
+ conn.prepareStatement(
+ """CREATE TABLE "test"."cache_t" (id decimal(25) PRIMARY KEY NOT NULL,
+ |name TEXT(32) NOT NULL)""".stripMargin).executeUpdate()
+ }
+ sql("INSERT OVERWRITE h2.test.cache_t SELECT 1 AS id, 'a' AS name")
+ sql("CACHE TABLE t1 SELECT id, name FROM h2.test.cache_t")
+ val plan = sql("select * from t1").queryExecution.sparkPlan
+ assert(plan.isInstanceOf[InMemoryTableScanExec])
+ sql("UNCACHE TABLE IF EXISTS t1")
Review Comment:
thanks， I has removed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table [spark]
Posted by "lyy-pineapple (via GitHub)" <gi...@apache.org>.
lyy-pineapple commented on PR #43258:
URL: https://github.com/apache/spark/pull/43258#issuecomment-1751931802
Could you review this PR when you get a chance @cloud-fan @MaxGekk @sigmod
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table [spark]
Posted by "lyy-pineapple (via GitHub)" <gi...@apache.org>.
lyy-pineapple commented on code in PR #43258:
URL: https://github.com/apache/spark/pull/43258#discussion_r1349478338
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala:
##########
@@ -512,4 +513,19 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
assert(t.schema === replaced)
}
}
+
+ test("SPARK-45449: Cache Invalidation Issue with JDBC Table") {
+ withConnection { conn =>
+ conn.prepareStatement(
+ """CREATE TABLE "test"."cache_t" (id decimal(25) PRIMARY KEY NOT NULL,
+ |name TEXT(32) NOT NULL)""".stripMargin).executeUpdate()
+ }
+ val ss = spark.cloneSession()
+ ss.sql("insert overwrite h2.test.cache_t select 1 as id, 'a' as name")
+
+ sql("cache table ct1 select id, name from h2.test.cache_t")
+ val plan = sql("select * from ct1").queryExecution.sparkPlan
+ assert(plan.isInstanceOf[InMemoryTableScanExec])
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45449][SQL] Cache Invalidation Issue with JDBC Table [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #43258:
URL: https://github.com/apache/spark/pull/43258#discussion_r1349470075
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala:
##########
@@ -512,4 +513,19 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
assert(t.schema === replaced)
}
}
+
+ test("SPARK-45449: Cache Invalidation Issue with JDBC Table") {
+ withConnection { conn =>
+ conn.prepareStatement(
+ """CREATE TABLE "test"."cache_t" (id decimal(25) PRIMARY KEY NOT NULL,
+ |name TEXT(32) NOT NULL)""".stripMargin).executeUpdate()
+ }
+ val ss = spark.cloneSession()
+ ss.sql("insert overwrite h2.test.cache_t select 1 as id, 'a' as name")
+
+ sql("cache table ct1 select id, name from h2.test.cache_t")
+ val plan = sql("select * from ct1").queryExecution.sparkPlan
+ assert(plan.isInstanceOf[InMemoryTableScanExec])
Review Comment:
Please clear the table cache and drop table at finally block.
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalogSuite.scala:
##########
@@ -512,4 +513,19 @@ class JDBCTableCatalogSuite extends QueryTest with SharedSparkSession {
assert(t.schema === replaced)
}
}
+
+ test("SPARK-45449: Cache Invalidation Issue with JDBC Table") {
+ withConnection { conn =>
+ conn.prepareStatement(
+ """CREATE TABLE "test"."cache_t" (id decimal(25) PRIMARY KEY NOT NULL,
+ |name TEXT(32) NOT NULL)""".stripMargin).executeUpdate()
+ }
+ val ss = spark.cloneSession()
Review Comment:
Why need clone session here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org