You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/13 00:49:18 UTC

[GitHub] [incubator-superset] ktmud opened a new pull request #9513: Collect frontend code coverage from Cypress tests

ktmud opened a new pull request #9513: Collect frontend code coverage from Cypress tests
URL: https://github.com/apache/incubator-superset/pull/9513
 
 
   ### CATEGORY
   
   - [x] Build / Development Environment
   
   ### SUMMARY
   
   College frontend code coverage from Cypress tests, too. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   
   N/A
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on issue #9513: [Build] Collect frontend code coverage from Cypress tests

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9513: [Build] Collect frontend code coverage from Cypress tests
URL: https://github.com/apache/incubator-superset/pull/9513#issuecomment-612704212
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=h1) Report
   > Merging [#9513](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a797465ae5b1f0064a0620d7511ec9bcffe8c1dc&el=desc) will **increase** coverage by `6.58%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9513/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9513      +/-   ##
   ==========================================
   + Coverage   58.57%   65.15%   +6.58%     
   ==========================================
     Files         386      386              
     Lines       12287    12287              
     Branches     3025     3025              
   ==========================================
   + Hits         7197     8006     +809     
   + Misses       4906     4123     -783     
   + Partials      184      158      -26     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `48.78% <ø> (?)` | |
   | #javascript | `58.57% <ø> (?)` | |
   | #ui | `48.78% <ø> (?)` | |
   | #unittest | `58.57% <ø> (?)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (+0.65%)` | :arrow_up: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.84% <0.00%> (+1.28%)` | :arrow_up: |
   | [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `36.36% <0.00%> (+1.51%)` | :arrow_up: |
   | [superset-frontend/src/utils/common.js](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvbW1vbi5qcw==) | `69.64% <0.00%> (+1.78%)` | :arrow_up: |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `78.84% <0.00%> (+1.92%)` | :arrow_up: |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (+2.05%)` | :arrow_up: |
   | [...rset-frontend/src/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `94.73% <0.00%> (+2.10%)` | :arrow_up: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (+2.79%)` | :arrow_up: |
   | [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwudHN4) | `16.17% <0.00%> (+2.94%)` | :arrow_up: |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `81.34% <0.00%> (+2.98%)` | :arrow_up: |
   | ... and [76 more](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=footer). Last update [a797465...10a2ab9](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud closed pull request #9513: [Build] Collect frontend code coverage from Cypress tests

Posted by GitBox <gi...@apache.org>.
ktmud closed pull request #9513: [Build] Collect frontend code coverage from Cypress tests
URL: https://github.com/apache/incubator-superset/pull/9513
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io commented on issue #9513: [Build] Collect frontend code coverage from Cypress tests

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9513: [Build] Collect frontend code coverage from Cypress tests
URL: https://github.com/apache/incubator-superset/pull/9513#issuecomment-612704212
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=h1) Report
   > Merging [#9513](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a797465ae5b1f0064a0620d7511ec9bcffe8c1dc&el=desc) will **decrease** coverage by `27.80%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9513/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9513       +/-   ##
   ===========================================
   - Coverage   58.57%   30.77%   -27.81%     
   ===========================================
     Files         386       74      -312     
     Lines       12287     3214     -9073     
     Branches     3025      698     -2327     
   ===========================================
   - Hits         7197      989     -6208     
   + Misses       4906     2130     -2776     
   + Partials      184       95       -89     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `30.77% <ø> (?)` | |
   | #ui | `30.77% <ø> (?)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/utils/safeStringify.ts](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3NhZmVTdHJpbmdpZnkudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/components/Timer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGltZXIuanN4) | `12.50% <0.00%> (-84.38%)` | :arrow_down: |
   | [...uperset-frontend/src/utils/getClientErrorObject.js](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0Lmpz) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
   | [superset-frontend/src/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGluay50c3g=) | `7.69% <0.00%> (-79.81%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/TableElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmxlRWxlbWVudC5qc3g=) | `4.59% <0.00%> (-78.17%)` | :arrow_down: |
   | [...src/components/FilterableTable/FilterableTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRmlsdGVyYWJsZVRhYmxlL0ZpbHRlcmFibGVUYWJsZS5qc3g=) | `4.39% <0.00%> (-76.38%)` | :arrow_down: |
   | [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `1.78% <0.00%> (-75.00%)` | :arrow_down: |
   | [...-frontend/src/SqlLab/components/HighlightedSql.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0hpZ2hsaWdodGVkU3FsLmpzeA==) | `16.66% <0.00%> (-73.34%)` | :arrow_down: |
   | [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `5.00% <0.00%> (-68.75%)` | :arrow_down: |
   | [...t-frontend/src/SqlLab/components/ColumnElement.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0NvbHVtbkVsZW1lbnQuanN4) | `33.33% <0.00%> (-66.67%)` | :arrow_down: |
   | ... and [356 more](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=footer). Last update [a797465...10a2ab9](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on issue #9513: [Build] Collect frontend code coverage from Cypress tests

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9513: [Build] Collect frontend code coverage from Cypress tests
URL: https://github.com/apache/incubator-superset/pull/9513#issuecomment-612704212
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=h1) Report
   > Merging [#9513](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a797465ae5b1f0064a0620d7511ec9bcffe8c1dc&el=desc) will **increase** coverage by `11.17%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9513/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9513       +/-   ##
   ===========================================
   + Coverage   58.57%   69.74%   +11.17%     
   ===========================================
     Files         386      386               
     Lines       12287    12287               
     Branches     3025     3025               
   ===========================================
   + Hits         7197     8570     +1373     
   + Misses       4906     3595     -1311     
   + Partials      184      122       -62     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `52.91% <ø> (?)` | |
   | #javascript | `58.57% <ø> (?)` | |
   | #ui | `52.91% <ø> (?)` | |
   | #unittest | `58.57% <ø> (?)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (+0.65%)` | :arrow_up: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.84% <0.00%> (+1.28%)` | :arrow_up: |
   | [superset-frontend/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS5qc3g=) | `81.69% <0.00%> (+1.40%)` | :arrow_up: |
   | [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==) | `36.36% <0.00%> (+1.51%)` | :arrow_up: |
   | [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4) | `71.87% <0.00%> (+1.56%)` | :arrow_up: |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `81.35% <0.00%> (+1.69%)` | :arrow_up: |
   | [superset-frontend/src/utils/common.js](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2NvbW1vbi5qcw==) | `69.64% <0.00%> (+1.78%)` | :arrow_up: |
   | [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC5qc3g=) | `78.84% <0.00%> (+1.92%)` | :arrow_up: |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (+2.05%)` | :arrow_up: |
   | [...rset-frontend/src/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `94.73% <0.00%> (+2.10%)` | :arrow_up: |
   | ... and [134 more](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=footer). Last update [a797465...10a2ab9](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] ktmud commented on issue #9513: [Build] Collect frontend code coverage from Cypress tests

Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #9513: [Build] Collect frontend code coverage from Cypress tests
URL: https://github.com/apache/incubator-superset/pull/9513#issuecomment-612704611
 
 
   I think GitHub + Travis just works very badly with force push.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] codecov-io edited a comment on issue #9513: [Build] Collect frontend code coverage from Cypress tests

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9513: [Build] Collect frontend code coverage from Cypress tests
URL: https://github.com/apache/incubator-superset/pull/9513#issuecomment-612704212
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=h1) Report
   > Merging [#9513](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a797465ae5b1f0064a0620d7511ec9bcffe8c1dc&el=desc) will **increase** coverage by `0.95%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9513/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9513      +/-   ##
   ==========================================
   + Coverage   58.57%   59.52%   +0.95%     
   ==========================================
     Files         386      386              
     Lines       12287    12287              
     Branches     3025     3025              
   ==========================================
   + Hits         7197     7314     +117     
   + Misses       4906     4801     -105     
   + Partials      184      172      -12     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `30.77% <ø> (?)` | |
   | #javascript | `58.57% <ø> (?)` | |
   | #ui | `30.77% <ø> (?)` | |
   | #unittest | `58.57% <ø> (?)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (+0.65%)` | :arrow_up: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.84% <0.00%> (+1.28%)` | :arrow_up: |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (+2.05%)` | :arrow_up: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (+2.79%)` | :arrow_up: |
   | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `81.34% <0.00%> (+2.98%)` | :arrow_up: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (+4.00%)` | :arrow_up: |
   | [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <0.00%> (+8.33%)` | :arrow_up: |
   | [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | `75.00% <0.00%> (+8.82%)` | :arrow_up: |
   | [superset-frontend/src/setup/setupApp.ts](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQXBwLnRz) | `24.13% <0.00%> (+24.13%)` | :arrow_up: |
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (+33.33%)` | :arrow_up: |
   | ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/9513/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=footer). Last update [a797465...10a2ab9](https://codecov.io/gh/apache/incubator-superset/pull/9513?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org