You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/12 19:53:13 UTC
[GitHub] [spark] MaxGekk opened a new pull request #28816: [WIP][SQL] Fix Julian-Gregorian micros rebasing while switching standard time zone offset
MaxGekk opened a new pull request #28816:
URL: https://github.com/apache/spark/pull/28816
### What changes were proposed in this pull request?
TODO
Note: The fix assumes that transitions cannot happen more often than once per 2 days.
### Why are the changes needed?
Current implementation handles timestamps overlapping only during daylight saving time but overlapping can happen also during transition from one standard time zone to another one. For example in the case of `Asia/Hong_Kong`, the time zone switched from `Japan Standard Time` (UTC+9) to `Hong Kong Time` (UTC+8) on _Sunday, 18 November, 1945 01:59:59 AM_. The changes allow to handle the special case as well.
### Does this PR introduce _any_ user-facing change?
It might affect micros rebasing in before common era when not-optimised version of `rebaseJulianToGregorianMicros()` is used directly.
### How was this patch tested?
1. By existing tests in `DateTimeUtilsSuite`, `RebaseDateTimeSuite`, `DateFunctionsSuite`, `DateExpressionsSuite` and `TimestampFormatterSuite`.
2. Added new checks to `RebaseDateTimeSuite`.`SPARK-31959: JST -> HKT at Asia/Hong_Kong in 1945`.
3. Regenerated `julian-gregorian-rebase-micros.json` with the step of 30 minutes, and got the same JSON file. The JSON file isn't affected because previously it was generated with the step of 1 week. And the spike in diffs/switch points during 1 hour of timestamp overlapping wasn't detected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #28816:
URL: https://github.com/apache/spark/pull/28816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-643751654
**[Test build #124006 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124006/testReport)** for PR 28816 at commit [`55a76bc`](https://github.com/apache/spark/commit/55a76bc0becff16ac8c7a80f4f1369599e359ba9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28816: [WIP][SQL] Fix Julian-Gregorian micros rebasing while switching standard time zone offset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-643751654
**[Test build #124006 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124006/testReport)** for PR 28816 at commit [`55a76bc`](https://github.com/apache/spark/commit/55a76bc0becff16ac8c7a80f4f1369599e359ba9).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-644404197
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-644226261
**[Test build #124063 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124063/testReport)** for PR 28816 at commit [`06ef8c0`](https://github.com/apache/spark/commit/06ef8c027b82529f153e13d1e047766e4db73230).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-644226261
**[Test build #124063 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124063/testReport)** for PR 28816 at commit [`06ef8c0`](https://github.com/apache/spark/commit/06ef8c027b82529f153e13d1e047766e4db73230).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28816: [WIP][SQL] Fix Julian-Gregorian micros rebasing while switching standard time zone offset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-643751750
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-643784685
**[Test build #124006 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124006/testReport)** for PR 28816 at commit [`55a76bc`](https://github.com/apache/spark/commit/55a76bc0becff16ac8c7a80f4f1369599e359ba9).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-643784950
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-644222849
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-644222863
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-643967758
let's wait until https://github.com/apache/spark/pull/28809 is merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-643784950
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-643804818
@cloud-fan @HyukjinKwon Please, review the fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-644404197
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #28816: [WIP][SQL] Fix Julian-Gregorian micros rebasing while switching standard time zone offset
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-643458925
**[Test build #123942 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123942/testReport)** for PR 28816 at commit [`4ebe742`](https://github.com/apache/spark/commit/4ebe7420b95498f1f28d097c49bb3a3343033f27).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28816: [WIP][SQL] Fix Julian-Gregorian micros rebasing while switching standard time zone offset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-643531844
**[Test build #123942 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123942/testReport)** for PR 28816 at commit [`4ebe742`](https://github.com/apache/spark/commit/4ebe7420b95498f1f28d097c49bb3a3343033f27).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-644548956
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28816: [WIP][SQL] Fix Julian-Gregorian micros rebasing while switching standard time zone offset
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-643458925
**[Test build #123942 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/123942/testReport)** for PR 28816 at commit [`4ebe742`](https://github.com/apache/spark/commit/4ebe7420b95498f1f28d097c49bb3a3343033f27).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28816: [WIP][SQL] Fix Julian-Gregorian micros rebasing while switching standard time zone offset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-643459471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #28816: [SPARK-31986][SQL] Fix Julian-Gregorian micros rebasing of overlapping local timestamps
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-644403131
**[Test build #124063 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/124063/testReport)** for PR 28816 at commit [`06ef8c0`](https://github.com/apache/spark/commit/06ef8c027b82529f153e13d1e047766e4db73230).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28816: [WIP][SQL] Fix Julian-Gregorian micros rebasing while switching standard time zone offset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-643459471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28816: [WIP][SQL] Fix Julian-Gregorian micros rebasing while switching standard time zone offset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-643532121
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #28816: [WIP][SQL] Fix Julian-Gregorian micros rebasing while switching standard time zone offset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-643532121
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #28816: [WIP][SQL] Fix Julian-Gregorian micros rebasing while switching standard time zone offset
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #28816:
URL: https://github.com/apache/spark/pull/28816#issuecomment-643751750
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org