[GitHub] [incubator-dolphinscheduler] zhuangchong commented on a change in pull request #3979: [Feature-3754][Alert] Alert module support service for other service invoke

[GitBox <gi...@apache.org>]

zhuangchong commented on a change in pull request #3979:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3979#discussion_r513367071



##########
File path: dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java
##########
@@ -118,10 +139,34 @@ public void start() {
         }
     }
 
+    /**
+     * start
+     */
+    public void start() {
+        initPlugin();
+        initRemoteServer();
+        logger.info("alert server ready start ");
+        runSender();
+    }
+
+    /**
+     * stop
+     */
+    public void stop() {
+        this.server.close();
+        logger.info("alert server shut down");
+    }
+
     public static void main(String[] args) {
         System.out.println(System.getProperty("user.dir"));

Review comment:
       System.out.println is not clear who added it, so I did not move.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org