[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #13345: Fix typo in functions-work.yaml, add functionWebServiceUrl in yaml

[GitBox <gi...@apache.org>]

michaeljmarshall commented on a change in pull request #13345:
URL: https://github.com/apache/pulsar/pull/13345#discussion_r770753101



##########
File path: conf/functions_worker.yml
##########
@@ -57,6 +57,7 @@ pulsarServiceUrl: pulsar://localhost:6650
 # For TLS:
 # webServiceUrl=https://localhost:8443/
 pulsarWebServiceUrl: http://localhost:8080
+functionWebServiceUrl: http://localhost:8080

Review comment:
       I think this will change the behavior of the following code if `workerHostname` is overridden in this file and the operator is relying on the following conditional to set the `functionWebServiceUrl`. Why do we need to add this to the configuration?
   
   https://github.com/apache/pulsar/blob/64bbbd499736825d60a778718b2e7834163d998b/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/PulsarWorkerService.java#L432-L435
   
   https://github.com/apache/pulsar/blob/64bbbd499736825d60a778718b2e7834163d998b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java#L618-L620
   
   https://github.com/apache/pulsar/blob/64bbbd499736825d60a778718b2e7834163d998b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java#L599-L604




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org