You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "dqhl76 (via GitHub)" <gi...@apache.org> on 2023/05/24 13:45:12 UTC
[GitHub] [incubator-opendal] dqhl76 opened a new pull request, #2310: docs: add service doc for azdfs
dqhl76 opened a new pull request, #2310:
URL: https://github.com/apache/incubator-opendal/pull/2310
Update https://github.com/apache/incubator-opendal/issues/2304
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #2310: docs: add service doc for azdfs
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #2310:
URL: https://github.com/apache/incubator-opendal/pull/2310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2310: docs: add service doc for azdfs
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2310:
URL: https://github.com/apache/incubator-opendal/pull/2310#discussion_r1204182167
##########
website/docs/services/azdfs.mdx:
##########
@@ -0,0 +1,69 @@
+---
+title: Azdfs
+---
+
+Azure Data Lake Storage Gen2 Support.
+
+import Docs from '../../../core/src/services/azdfs/docs.md'
+
+<Docs components={props.components} />
+
+
+### Via Config
+
+import Tabs from '@theme/Tabs';
+import TabItem from '@theme/TabItem';
+
+<Tabs>
+ <TabItem value="rust" label="Rust" default>
+
+```rust
+use std::sync::Arc;
+use anyhow::Result;
+use opendal::services::Azdfs;
Review Comment:
We should `use opendal::Scheme;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #2310: docs: add service doc for azdfs
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2310:
URL: https://github.com/apache/incubator-opendal/pull/2310#issuecomment-1561216787
> May be we also need to add `use opendal::Scheme;` for this
>
> https://github.com/apache/incubator-opendal/blob/a189eef962c8e2a30a371845d4aa0499c5c24803/website/docs/services/azblob.mdx?plain=1#L35
Yes, and we can remove `use opendal::services::Azdfs`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on pull request #2310: docs: add service doc for azdfs
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #2310:
URL: https://github.com/apache/incubator-opendal/pull/2310#issuecomment-1561214434
May be we also need to add `use opendal::Scheme;` for this https://github.com/apache/incubator-opendal/blob/a189eef962c8e2a30a371845d4aa0499c5c24803/website/docs/services/azblob.mdx?plain=1#L35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org