You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/10/04 16:16:04 UTC

[GitHub] fabianmenges opened a new pull request #3594: [Bugfix]: Fxing bug in label generation for multiple groupbys

fabianmenges opened a new pull request #3594: [Bugfix]: Fxing bug in label generation for multiple groupbys
URL: https://github.com/apache/incubator-superset/pull/3594
 
 
   Fixes: #3590 
   Relates to:  #3504 #3563 #3566
   
   I guess I started this so I'll take 99% of the blame here:
   
   ## History:
   
   1. #3504 caused a bug where the metric names would be displayed in the legend even when there was only one metric.
   2. #3563 fixed that bug, but caused #3590 where the legend for multiple group by s does not get generated correctly
   3. #3566 would have fixed both issues but came too late
   
   So we either apply this fix or roll back #3563 and apply #3566 
   
   Hopefully this is the last issue :(
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services