You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/06/30 08:52:07 UTC

[GitHub] [spark] panbingkun commented on a diff in pull request #41794: [SPARK-44254][SQL] Move QueryExecutionErrors to sql/api

panbingkun commented on code in PR #41794:
URL: https://github.com/apache/spark/pull/41794#discussion_r1247615047


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala:
##########
@@ -24,6 +24,7 @@ import scala.util.Try
 import org.apache.spark.annotation.Unstable
 import org.apache.spark.sql.catalyst.trees.SQLQueryContext
 import org.apache.spark.sql.errors.QueryExecutionErrors
+import org.apache.spark.sql.errors.SqlApiQueryExecutionErrors

Review Comment:
   Do other similar items need to be moved? eg:
   QueryExecutionErrors.unscaledValueTooLargeForPrecisionError(this, precision, scale)
   It seems that it is only called in `DataType`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org