You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martijn Dashorst (JIRA)" <ji...@apache.org> on 2008/03/10 18:12:49 UTC
[jira] Created: (WICKET-1409) RequestLogger counts active requests
wrong
RequestLogger counts active requests wrong
------------------------------------------
Key: WICKET-1409
URL: https://issues.apache.org/jira/browse/WICKET-1409
Project: Wicket
Issue Type: Bug
Affects Versions: 1.3.1, 1.3.0-final
Reporter: Martijn Dashorst
The request logger doesn't decrease the number of active requests correctly in wicket 1.3.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (WICKET-1409) RequestLogger counts active requests
wrong
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst closed WICKET-1409.
------------------------------------
Resolution: Fixed
Fix Version/s: (was: 1.3.5)
1.3.4
Looking at our application, this has been fixed.
> RequestLogger counts active requests wrong
> ------------------------------------------
>
> Key: WICKET-1409
> URL: https://issues.apache.org/jira/browse/WICKET-1409
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-final, 1.3.1
> Reporter: Martijn Dashorst
> Assignee: Johan Compagner
> Fix For: 1.3.4
>
>
> The request logger doesn't decrease the number of active requests correctly in wicket 1.3.
> New data when running in debugger. The active request count is updated when the request logger data is put into the session (why?):
> RequestLogger.getCurrentRequest() line: 192
> RequestLogger.objectUpdated(Object) line: 365
> Application$1(HttpSessionStore).setAttribute(Request, String, Object) line: 153
> Application$1(SecondLevelCacheSessionStore).setAttribute(Request, String, Object) line: 721
> IridiumSession(Session).setAttribute(String, Object) line: 1281
> IridiumSession(Session).requestDetached() line: 1381
> IridiumRequestCycle(RequestCycle).detach() line: 1091
> IridiumRequestCycle(RequestCycle).steps() line: 1348
> IridiumRequestCycle(RequestCycle).request() line: 493
> WicketFilter.doGet(HttpServletRequest, HttpServletResponse) line: 358
> WicketFilter.doFilter(ServletRequest, ServletResponse, FilterChain) line: 194
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1409) RequestLogger counts active
requests wrong
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577177#action_12577177 ]
Johan Compagner commented on WICKET-1409:
-----------------------------------------
any idea why?
or how to reproduce?
we do have a session listener right?
> RequestLogger counts active requests wrong
> ------------------------------------------
>
> Key: WICKET-1409
> URL: https://issues.apache.org/jira/browse/WICKET-1409
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-final, 1.3.1
> Reporter: Martijn Dashorst
>
> The request logger doesn't decrease the number of active requests correctly in wicket 1.3.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1409) RequestLogger counts active requests
wrong
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-1409:
-------------------------------------
Description:
The request logger doesn't decrease the number of active requests correctly in wicket 1.3.
New data when running in debugger. The active request count is updated when the request logger data is put into the session (why?):
RequestLogger.getCurrentRequest() line: 192
RequestLogger.objectUpdated(Object) line: 365
Application$1(HttpSessionStore).setAttribute(Request, String, Object) line: 153
Application$1(SecondLevelCacheSessionStore).setAttribute(Request, String, Object) line: 721
IridiumSession(Session).setAttribute(String, Object) line: 1281
IridiumSession(Session).requestDetached() line: 1381
IridiumRequestCycle(RequestCycle).detach() line: 1091
IridiumRequestCycle(RequestCycle).steps() line: 1348
IridiumRequestCycle(RequestCycle).request() line: 493
WicketFilter.doGet(HttpServletRequest, HttpServletResponse) line: 358
WicketFilter.doFilter(ServletRequest, ServletResponse, FilterChain) line: 194
was:The request logger doesn't decrease the number of active requests correctly in wicket 1.3.
> RequestLogger counts active requests wrong
> ------------------------------------------
>
> Key: WICKET-1409
> URL: https://issues.apache.org/jira/browse/WICKET-1409
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-final, 1.3.1
> Reporter: Martijn Dashorst
> Assignee: Johan Compagner
> Fix For: 1.3.4
>
>
> The request logger doesn't decrease the number of active requests correctly in wicket 1.3.
> New data when running in debugger. The active request count is updated when the request logger data is put into the session (why?):
> RequestLogger.getCurrentRequest() line: 192
> RequestLogger.objectUpdated(Object) line: 365
> Application$1(HttpSessionStore).setAttribute(Request, String, Object) line: 153
> Application$1(SecondLevelCacheSessionStore).setAttribute(Request, String, Object) line: 721
> IridiumSession(Session).setAttribute(String, Object) line: 1281
> IridiumSession(Session).requestDetached() line: 1381
> IridiumRequestCycle(RequestCycle).detach() line: 1091
> IridiumRequestCycle(RequestCycle).steps() line: 1348
> IridiumRequestCycle(RequestCycle).request() line: 493
> WicketFilter.doGet(HttpServletRequest, HttpServletResponse) line: 358
> WicketFilter.doFilter(ServletRequest, ServletResponse, FilterChain) line: 194
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1409) RequestLogger counts active
requests wrong
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596322#action_12596322 ]
Johan Compagner commented on WICKET-1409:
-----------------------------------------
its not about the data put into the session
its when the first call to getCurrentRequest() is being done. on the request logger.
What that is and where it comes from can be anything.
> RequestLogger counts active requests wrong
> ------------------------------------------
>
> Key: WICKET-1409
> URL: https://issues.apache.org/jira/browse/WICKET-1409
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-final, 1.3.1
> Reporter: Martijn Dashorst
> Assignee: Johan Compagner
> Fix For: 1.3.4
>
>
> The request logger doesn't decrease the number of active requests correctly in wicket 1.3.
> New data when running in debugger. The active request count is updated when the request logger data is put into the session (why?):
> RequestLogger.getCurrentRequest() line: 192
> RequestLogger.objectUpdated(Object) line: 365
> Application$1(HttpSessionStore).setAttribute(Request, String, Object) line: 153
> Application$1(SecondLevelCacheSessionStore).setAttribute(Request, String, Object) line: 721
> IridiumSession(Session).setAttribute(String, Object) line: 1281
> IridiumSession(Session).requestDetached() line: 1381
> IridiumRequestCycle(RequestCycle).detach() line: 1091
> IridiumRequestCycle(RequestCycle).steps() line: 1348
> IridiumRequestCycle(RequestCycle).request() line: 493
> WicketFilter.doGet(HttpServletRequest, HttpServletResponse) line: 358
> WicketFilter.doFilter(ServletRequest, ServletResponse, FilterChain) line: 194
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1409) RequestLogger counts active requests
wrong
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-1409:
-------------------------------------
Fix Version/s: (was: 1.3.4)
1.3.5
> RequestLogger counts active requests wrong
> ------------------------------------------
>
> Key: WICKET-1409
> URL: https://issues.apache.org/jira/browse/WICKET-1409
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-final, 1.3.1
> Reporter: Martijn Dashorst
> Assignee: Johan Compagner
> Fix For: 1.3.5
>
>
> The request logger doesn't decrease the number of active requests correctly in wicket 1.3.
> New data when running in debugger. The active request count is updated when the request logger data is put into the session (why?):
> RequestLogger.getCurrentRequest() line: 192
> RequestLogger.objectUpdated(Object) line: 365
> Application$1(HttpSessionStore).setAttribute(Request, String, Object) line: 153
> Application$1(SecondLevelCacheSessionStore).setAttribute(Request, String, Object) line: 721
> IridiumSession(Session).setAttribute(String, Object) line: 1281
> IridiumSession(Session).requestDetached() line: 1381
> IridiumRequestCycle(RequestCycle).detach() line: 1091
> IridiumRequestCycle(RequestCycle).steps() line: 1348
> IridiumRequestCycle(RequestCycle).request() line: 493
> WicketFilter.doGet(HttpServletRequest, HttpServletResponse) line: 358
> WicketFilter.doFilter(ServletRequest, ServletResponse, FilterChain) line: 194
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1409) RequestLogger counts active requests
wrong
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Johan Compagner updated WICKET-1409:
------------------------------------
Fix Version/s: 1.3.3
Assignee: Johan Compagner
i dont see how the active request are going wrong..
it is increased when a RequestData object is created for the current thread/request
and it is decreased when the RequestLogger detaches and finishes the RequestData object.
> RequestLogger counts active requests wrong
> ------------------------------------------
>
> Key: WICKET-1409
> URL: https://issues.apache.org/jira/browse/WICKET-1409
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-final, 1.3.1
> Reporter: Martijn Dashorst
> Assignee: Johan Compagner
> Fix For: 1.3.3
>
>
> The request logger doesn't decrease the number of active requests correctly in wicket 1.3.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1409) RequestLogger counts active
requests wrong
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596352#action_12596352 ]
Martijn Dashorst commented on WICKET-1409:
------------------------------------------
Seems to work for us.
> RequestLogger counts active requests wrong
> ------------------------------------------
>
> Key: WICKET-1409
> URL: https://issues.apache.org/jira/browse/WICKET-1409
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-final, 1.3.1
> Reporter: Martijn Dashorst
> Assignee: Johan Compagner
> Fix For: 1.3.4
>
>
> The request logger doesn't decrease the number of active requests correctly in wicket 1.3.
> New data when running in debugger. The active request count is updated when the request logger data is put into the session (why?):
> RequestLogger.getCurrentRequest() line: 192
> RequestLogger.objectUpdated(Object) line: 365
> Application$1(HttpSessionStore).setAttribute(Request, String, Object) line: 153
> Application$1(SecondLevelCacheSessionStore).setAttribute(Request, String, Object) line: 721
> IridiumSession(Session).setAttribute(String, Object) line: 1281
> IridiumSession(Session).requestDetached() line: 1381
> IridiumRequestCycle(RequestCycle).detach() line: 1091
> IridiumRequestCycle(RequestCycle).steps() line: 1348
> IridiumRequestCycle(RequestCycle).request() line: 493
> WicketFilter.doGet(HttpServletRequest, HttpServletResponse) line: 358
> WicketFilter.doFilter(ServletRequest, ServletResponse, FilterChain) line: 194
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1409) RequestLogger counts active requests
wrong
Posted by "Frank Bille Jensen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Frank Bille Jensen updated WICKET-1409:
---------------------------------------
Fix Version/s: (was: 1.3.3)
1.3.4
> RequestLogger counts active requests wrong
> ------------------------------------------
>
> Key: WICKET-1409
> URL: https://issues.apache.org/jira/browse/WICKET-1409
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.3.0-final, 1.3.1
> Reporter: Martijn Dashorst
> Assignee: Johan Compagner
> Fix For: 1.3.4
>
>
> The request logger doesn't decrease the number of active requests correctly in wicket 1.3.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.