You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/16 23:23:00 UTC

[jira] [Commented] (BEAM-2459) Remove no-op UnsupportedOperationVisitor

    [ https://issues.apache.org/jira/browse/BEAM-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052511#comment-16052511 ] 

ASF GitHub Bot commented on BEAM-2459:
--------------------------------------

GitHub user takidau opened a pull request:

    https://github.com/apache/beam/pull/3384

    [BEAM-2459] Remove UnsupportedOperationVisitor, which is currently just a no-op

    AFAICT, UnsupportedOperationVisitor just extends SqlShuttle with no overrides, which means it does nothing when it visits SqlNodes. As such, the one use of it in BeamQueryPlanner is a no-op. Removing, unless there is a good reason not to.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/takidau/beam BEAM-2459

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3384
    
----
commit 5276d2381cb638e01ada16b09dd52cdda286590e
Author: Tyler Akidau <ta...@apache.org>
Date:   2017-06-16T23:16:46Z

    Remove UnsupportOperationVisitor, which is currently just a no-op

----


> Remove no-op UnsupportedOperationVisitor
> ----------------------------------------
>
>                 Key: BEAM-2459
>                 URL: https://issues.apache.org/jira/browse/BEAM-2459
>             Project: Beam
>          Issue Type: Task
>          Components: dsl-sql
>            Reporter: Tyler Akidau
>            Assignee: Tyler Akidau
>
> UnsupportedOperationVisitor appears to simply extend Calcite's SqlShuttle, with no overrides, which means nothing actually happens when it's used. We should remove it unless I'm missing something or there's a plan to use it differently in the future.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)