You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sergio Pena via Review Board <no...@reviews.apache.org> on 2018/11/15 16:00:54 UTC
Review Request 69349: SENTRY-2457: Reuse connection objects on
TestConcurrentClients#testConcurrentHS2Client
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69349/
-----------------------------------------------------------
Review request for sentry and Arjun Mishra.
Bugs: semtry-2457
https://issues.apache.org/jira/browse/semtry-2457
Repository: sentry
Description
-------
Re-use the Connection object on the TestConcurrentClient#testConcurrentHS2Client method. This increase the speed of the test 10s.
Diffs
-----
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestConcurrentClients.java 2da6c6b8231ff2e59c302c1ecc857f852d7a28ee
Diff: https://reviews.apache.org/r/69349/diff/1/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 69349: SENTRY-2457: Reuse connection objects on
TestConcurrentClients#testConcurrentHS2Client
Posted by Arjun Mishra via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69349/#review210584
-----------------------------------------------------------
Ship it!
Ship It!
- Arjun Mishra
On Nov. 15, 2018, 4 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69349/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2018, 4 p.m.)
>
>
> Review request for sentry and Arjun Mishra.
>
>
> Bugs: semtry-2457
> https://issues.apache.org/jira/browse/semtry-2457
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Re-use the Connection object on the TestConcurrentClient#testConcurrentHS2Client method. This increase the speed of the test 10s.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestConcurrentClients.java 2da6c6b8231ff2e59c302c1ecc857f852d7a28ee
>
>
> Diff: https://reviews.apache.org/r/69349/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>