[GitHub] [ozone] JyotinderSingh commented on pull request #3364: HDDS-6666. Make Hugo markdown image syntax add responsive image class

[GitBox <gi...@apache.org>]

JyotinderSingh commented on PR #3364:
URL: https://github.com/apache/ozone/pull/3364#issuecomment-1113440190

   Hi @smengcl thank you for the patch, just to make sure I understand the functionality correctly - the change you have added automatically substitutes every Markdown img tag with the custom code `<img src="{{ .Destination | safeURL }}" alt='{{ .Text }}' class="img-responsive"/>`? I believe it's called a [render hook](https://gohugo.io/templates/render-hooks/), could you please confirm if I am understanding it properly?
   
   Adding to what @adoroszlai said, currently, the only reason the website does not have the image sizing fix added is that we are skipping the logic added in #3122 in the deployment process because our Jenkins server does not have Maven installed. For the image sizing logic to work correctly, we should use the `mvn clean install` command to generate the website.
   
   Looking at the logic that you have added, I think it completely resolves the issue in my approach (having to generate site using `mvn clean install`) and is a more elegant and understandable solution. I think you should be able to safely remove the the changes linked below in `hadoop-hdds/docs/dev-support/bin/generate-site.sh` I made as a part of #3122.
   https://github.com/apache/ozone/pull/3122/files#diff-d9443550225fa81eaea96777ca3c5f615fff136ac1d2fd58dc789e2a458107fcR34-R46


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org