You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by jo...@gmail.com on 2010/04/06 20:39:29 UTC

Re: Improvements to XhrWrapper (issue841044)

LGTM, patching and committing (w/ tiny update here).

Re: getFullHeaders, the spec says nothing about our filtering, which I
recall was done for bandwidth-saving reasons rather than security. If
anyone here has an issue w/ this, please chime in.


http://codereview.appspot.com/841044/diff/1/11
File features/src/main/javascript/features/xhrwrapper/xhrwrapper.js
(right):

http://codereview.appspot.com/841044/diff/1/11#newcode181
features/src/main/javascript/features/xhrwrapper/xhrwrapper.js:181:
params[gadgets.io.RequestParameters.AUTHORIZATION] =
gadgets.io.AuthorizationType.OAUTH;
nit: tab found here rather than spaces

http://codereview.appspot.com/841044/show